Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up attributes appendix #225

Open
jarek-foksa opened this issue Aug 1, 2016 · 6 comments
Open

Tidy up attributes appendix #225

jarek-foksa opened this issue Aug 1, 2016 · 6 comments

Comments

@jarek-foksa
Copy link

The table on https://svgwg.org/svg2-draft/attindex.html needs to be updated so that width and height attributes on <image> are marked as animatable.

@AmeliaBR AmeliaBR added this to the SVG Core clean-up milestone Aug 7, 2016
@AmeliaBR AmeliaBR changed the title Mark "width" and "height" attributes on <image> as animatable Tidy up attributes appendix Aug 7, 2016
@AmeliaBR
Copy link
Contributor

AmeliaBR commented Aug 7, 2016

That row should actually be removed, and x/y/width/height for image listed as presentation attributes. Except we seem to have dropped the section of the table that listed the geometry presentation attributes & which elements they apply to. (And that's a rather important distinction, since some attributes by those names will affect CSS computed styles and some won't!)

There are a number of other issues I noticed in there, so I'm broadening this issue to be a general clean-up.

@jarek-foksa
Copy link
Author

There are three more presentation attributes listed: gradientTransform, patternTransform and transform.

@jarek-foksa
Copy link
Author

Except we seem to have dropped the section of the table that listed the geometry presentation attributes & which elements they apply to.

It looks like that table has been moved to https://svgwg.org/svg2-draft/styling.html#PresentationAttributes. I would merge it with the property index.

AmeliaBR added a commit that referenced this issue Aug 24, 2016
Major changes:

- defines consistent layout rules for all embedded elements using the geometry properties (as discussed in #237)
- removes redundant/conflicting definitions of x/y/width/height (closes #237)
- explicitly states that min/max-width/height properties can be used to constrain width/height (closes #238)
- defines the behavior of `object-fit` and `object-position` for embedded elements, including its interaction with `preserveAspectRatio` for `image` (closes #239)
- update the definition of `preserveAspectRatio` for `image` to be consistent with CSS sizing
- add clarifying note about the behavior of `overflow` on image and why it was changed with respect to SVG 1.1 and embedded SVG images
- Add warning about the HTML parser not currently supporting HTML embedded content elements in SVG fragments (as discussed in #240)
- Re-organized and updated the `foreignObject` section to reflect that XML does not rule the world; added warning about `requiredExtensions` not currently being defined in any useful way.
- Moved the section on foreign namespaced private data to the Document Structure chapter.
- Updated the note on `<base>` and its impact on cross-references to reflect changes made elsewhere.
- Re-organized the "presentation attributes" table in the Styling chapter, updating to match changes elsewhere (addresses some of the issues discussed in #225)
- Change the `overflow` rules so that `scroll` is expected to behave as normal for `foreignObject` and `iframe`.
- Updated the bounding box algorithm for the `clipped` flag to reflect all types of clipping on all types of elements (as discussed in #243)
- Updated changes appendix to match.
-
@SebastianZ
Copy link

SebastianZ commented Sep 1, 2016

Listing all elements on which an attribute can be specified looks like overkill to me. I suggest to replace them by element categories and link them to their definitions (which already exist for some of them).

Examples:

Attribute Elements on which the attribute may be specified Anim.
dur animation elements except <discard>
id all elements
intercept transfer function elements ✔️

Sebastian

@dirkschulze
Copy link
Contributor

Marking it for SVG 2.0 to clean-up the table but not necessarily fixing the actual proposal. If we get to it for 2.0, great! If not, will be a future item.

@dirkschulze
Copy link
Contributor

Checked the necessary parts and couldn't find changes required for SVG 2.0. Moving back to 2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants