Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #402 Use CCS Colour L4 definition for computed value of *-opacity #432

Merged
merged 1 commit into from
May 2, 2018

Conversation

dstorey
Copy link
Member

@dstorey dstorey commented May 2, 2018

No description provided.

@dstorey
Copy link
Member Author

dstorey commented May 2, 2018

Notes:

  • none of the CSS properties in pservers include a row for computed value, so I didn't change there. I just used the data type rather than number | percentage
  • solid-opacity is not included in propidx
  • flood-opacity is defined in the Filters spec. @dirkschulze: should that be updated to use alpha-value? it uses https://drafts.csswg.org/css-values-4/#typedef-number-percentage which is also number | percentage but is more general purpose (doesn't mention useful range being between 0 and 1)
  • doesn't this need a change log entry or tests? Feels more like tightening up to expected platform conventions.

@dirkschulze
Copy link
Contributor

@dstorey It would be great if you could open an issue on https://github.com/w3c/fxtf-drafts/issues so that I won't forget about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants