Use class="extract" to exclude IDL #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marked as non substantive for IPR from ash-nazg. |
dirkschulze
approved these changes
Aug 20, 2018
|
Whoops! This is breaking the build. (The processing.js scripts don't run on a full DOM objects, they run on a pseudo-DOM created with the Anyway: I'll fix it, but in future, @dirkschulze, please don't merge any changes to the tools/ files without running a test build! |
|
Whoops, sorry! BTW xmldom is being poorly maintained, perhaps we can use jsdom fragment mode instead to get proper DOM APIs. |
AmeliaBR
added a commit
that referenced
this pull request
Sep 4, 2018
Reverts commit 63a42e4 Creates the same effect using the build system: elements with the `edit:excludefromidl="true"` attribute in the source are given the class "extract" in the build. Which apparently has an effect in the Reffy system (for parsing the IDL of different specs), though I'm not sure exactly what. See w3c/reffy#123
|
See #539 for the fixes. |
AmeliaBR
added a commit
that referenced
this pull request
Sep 5, 2018
Revert & replace changes from PR #495
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what bikeshed does e.g. in CSSOM. It doesn't remove the flag so that IDL crawlers can also detect it.