Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor accessibility of the diff buttons #276

Open
svgeesus opened this issue Nov 10, 2021 · 1 comment
Open

Poor accessibility of the diff buttons #276

svgeesus opened this issue Nov 10, 2021 · 1 comment

Comments

@svgeesus
Copy link

From Léonie Watson:

one suggestion is to use the aria-pressed attribute instead of disabling the active button. The disabled attribute removes the button from the tab order, and it's easy to tab past it without realising it's there.

Working example is the light/dark mode toggle on my blog:

https://tink.uk

@fantasai
Copy link
Contributor

Maybe we need to recode this as radio buttons or something? aria-pressed talks to the accessibility APIs maybe, but for sighted mouse users it does nothing to indicate the fact that this button is pressed and clicking on it will not do anything. (We could use CSS to make it look disabled, of course, but at that point it seems like we're just building something out of pieces and hoping the assembly will work properly rather than using appropriate markup to begin with.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@fantasai @svgeesus and others