Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync scrolling if there's a 2-column layout #293

Closed
wants to merge 2 commits into from
Closed

Conversation

deniak
Copy link
Member

@deniak deniak commented Feb 2, 2022

The PR enable the scrolling of the 2 columns together if reduce motion is enabled.
See example: https://cdn.statically.io/gh/w3c/tr-design/2-column-scroll/src/README.html
Fix #287

@dontcallmedom
Copy link
Member

I now understand why you thought scrolling needed to be proportional to the height, but what I had in mind is different from what this PR produces: this PR keeps 2 different scrolling contexts (one for the TOC, one for the content), and when the TOC has been fully scrolled, it is then stuck.

My suggestion was to make the TOC part of the same scrolling context as the content, which means that it would simply start disappear once it reaches the bottom.

@deniak
Copy link
Member Author

deniak commented Feb 2, 2022

My suggestion was to make the TOC part of the same scrolling context as the content, which means that it would simply start disappear once it reaches the bottom.

Of course, that makes more sense. I updated the PR so simply include the MQ rules.

@dontcallmedom
Copy link
Member

I've verified locally that the updated result matches what I had in mind and I think addresses #287 , but I don't think the statically URL reflects the latest version unfortunately - anyway to trigger its update?

@deniak
Copy link
Member Author

deniak commented Feb 2, 2022

AFAIK, statically doesn't provide a way to invalidate the cache so we have to wait to it to be invalidated automatically (after 1 day) or use a different service.

@MarjaE2
Copy link

MarjaE2 commented Feb 2, 2022

For me, it starts off good, but then the left column runs out and the headaches start again.

@deniak deniak closed this Feb 3, 2022
@deniak deniak deleted the 2-column-scroll branch February 3, 2022 14:41
@deniak deniak mentioned this pull request Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

W3C specifications use a 2-column view, which is not universally accessible
3 participants