Fix type issue between get tt compliant string and validate string in context #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… context Get TT compliant string now takes any value, rather than just string or a TT. It then correctly stringifies this value. Fixes w3c#488
lukewarlow
force-pushed
the
fix-stringification
branch
from
f6ffcf6
to
c887020
Compare
lukewarlow
commented
Apr 4, 2024
| @@ -1022,19 +1022,21 @@ This algorithm will return a string that can be used with an | |||
| It will ensure that the Trusted Type [=enforcement=] rules were respected. | |||
|
|
|||
| Given a {{TrustedType}} type (|expectedType|), a [=realm/global object=] (|global|), | |||
| {{TrustedType}} or a string (|input|), a string (|sink|) and a string (|sinkGroup|), run these steps: | |||
| an [=ECMAScript language value=] (|input|), a string (|sink|) and a string (|sinkGroup|), run these steps: | |||
There was a problem hiding this comment.
If this now takes an ECMAScript language value which is what it's passed from the validate algorithm which gets it from WebIDL, does that "just work" for all the other uses of this algorithm? Or does it as I suspect break those call sites?
|
Going to go ahead and close this because we're going ahead with removing the extended attribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get TT compliant string now takes any value, rather than just string or a TT. It then correctly stringifies this value.
Fixes #488
Preview | Diff