-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis CI integration #262
Conversation
spec/build.xml
Outdated
<mkdir dir="${build.target}/xsd"/> | ||
<copy file="${html.dir}/${html.name}" tofile="${build.target}/index.html"/> | ||
<copy todir="${build.target}/images"> | ||
<fileset dir="${basedir}/images" includes="*.png"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least in TTML2 there are SVG images too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much better than what we had before, so I'm keen to merge it soon even if there are further tweaks that could be made.
I notice that it is possible to have build branch name clashes, since the same branch name can be reused (I know!), but this is unlikely to be a significant problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's really hard to review this commit on the GitHub web page because it treats the indentation changes as huge blocks of removed and added lines. Is it just changing the indentation, or were there other changes too?
There were other changes, including:
|
Ah, thanks, that was helpful! All looks fine to me. What action is needed about the lines that look like: <!-- DO NOT USE AS-IS --> ? |
These targets need to be at the very least modified — since they have hardcoded pub names. I plan on getting to them as we get closer to publication. In the meantime they should not be used. |
OK, no problem, the build script doesn't use them anyway. |
The build target does not use the sg and rg targets either. I thought I would keep mods to a minimum for now. The script will benefit from additional maintenance over time. |
build
target expands keywords