Clarified application of tts:visibility to child elements #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skynavga
requested changes
Nov 30, 2017
spec/ttml1.xml
Outdated
| @@ -5672,6 +5672,10 @@ each character child of a <el>p</el> element is considered to be enclosed in an | |||
| span.</p> | |||
| <p>The <att>tts:visibility</att> style has no affect on content layout or | |||
| composition, but merely determines whether composed content is visible or not.</p> | |||
| <p>If the computed value of the property associated with this attribute is visible, then areas generated | |||
There was a problem hiding this comment.
The 1st and 5th instances of 'visible' should be wrapped in <code>...</code>; likewise for the 1st instance of 'hidden'. This is to match the formatting in TTML2.
|
@skynavga Please review |
skynavga
approved these changes
Nov 30, 2017
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #207
Prose copied from TTML2