Improve overflow example #328
Conversation
spec/examples/ex4-overflow.xml
Outdated
| <head> | ||
| <styling> | ||
| <style xml:id="s1" tts:backgroundColor="black" tts:wrapOption="noWrap" tts:padding="6px"/> | ||
| <style xml:id="s2" tts:color="red" tts:backgroundColor="purple" tts:fontFamily="proportionalSansSerif" tts:fontSize="10px"/> |
There was a problem hiding this comment.
I'm finding the colour contrast between the purple and the red really horrible (and the luminance contrast is very low too) - please could you change one of them, e.g. change the purple to grey?
There was a problem hiding this comment.
Grey does not provide sufficient contrast with the background. Please pick another color.
spec/examples/ex4-overflow.xml
Outdated
| <tt xmlns="http://www.w3.org/ns/ttml" xmlns:tts="http://www.w3.org/ns/ttml#styling" xml:lang="en" tts:extent="320px 240px"> | ||
| <head> | ||
| <styling> | ||
| <style xml:id="s1" tts:backgroundColor="black" tts:wrapOption="noWrap" tts:padding="6px"/> |
There was a problem hiding this comment.
Why put tts:wrapOption in the region style? It seems inconsistent to do this but put tts:fontFamily and tts:fontSize in the p style - those three should probably all go on the same style, I don't mind which one.
spec/build.xml
Outdated
| <include name="ex4-overflow.xml"/> | ||
| </fileset> | ||
| </schemavalidate> | ||
| </target> | ||
|
|
||
| <target name="validate-examples" | ||
| depends="validate-example-1, validate-example-2, validate-example-3"/> |
There was a problem hiding this comment.
Need to add validate-example-4 to the dependencies here.
There was a problem hiding this comment.
(also, separately, I see that the build target does not call validate first, which it should)
Closes #320