Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text combine example is incorrect/misleading. #1128

Closed
palemieux opened this issue Jul 8, 2019 · 8 comments · Fixed by #1180 or #1187
Closed

Text combine example is incorrect/misleading. #1128

palemieux opened this issue Jul 8, 2019 · 8 comments · Fixed by #1180 or #1187

Comments

@palemieux
Copy link
Contributor

The note below the text combine example at https://www.w3.org/TR/ttml2/#style-attribute-textCombine implies that the render on the right uses different variants of the font for the affected characters. The latter however appear identical to the render on the left.

Suggest using the following render instead:

0 000000

@skynavga skynavga changed the title Text Combine example is incorrect/misleading Text Combine example is incorrect/misleading. Jul 23, 2019
@skynavga skynavga added this to the 3ED milestone Sep 22, 2019
@cconcolato
Copy link
Contributor

The proposed image does not exactly match the note either. The note says:

the presentation processor selected half-width variants of the affected characters, but the resulting width is larger than the em square of the surrounding vertical text

I'm fine with using the proposed image but the note would have to be changed.

This seems to be a simple editorial change. I would propose to keep it in scope for TTML2 2nd Ed.

@skynavga skynavga self-assigned this Oct 4, 2019
@skynavga skynavga modified the milestones: 3ED, 2ED-FPWD Oct 4, 2019
@skynavga
Copy link
Collaborator

skynavga commented Oct 4, 2019

The intent of the right-most line of the sample rendition and the note was to depict the case where the implementation expands the line are in the block progression dimension to accommodate tate-chu-yoko text that extends outside the EM square (without reducing font size); therefore, I will correct the note to match the current sample rendition (rather than replacing the rendition).

@palemieux
Copy link
Contributor Author

@skynavga Having an example that does not follow the recommended behavior (half-width variant forms may be selected, a ligature may be selected, a smaller font size may be applied, etc. At a minimum, an implementation that supports this style property must be able to select half-width variant forms if available) is not a good idea. Why can't the rendering above, or one generated using TTPE be used?

skynavga added a commit that referenced this issue Oct 20, 2019
Ensure note matches example rendition of tts:textCombine example (#1128).
@skynavga skynavga removed their assignment Oct 20, 2019
@cconcolato
Copy link
Contributor

I am missing something here?

The new text says:

In the above example, the rightmost region depicts the use of the all value, where the presentation processor has selected half-width variant glyphs for the affected characters, thus allowing the combined text to fit within same EM square as the surrounding vertical text.

The right-most image demonstrates more than selecting half-width variant glyphs. Some stretching is used also. I still find that confusing. I would either:

  • replace the XML snippet and images to select only 2 characters like '34' and then the note would be correct;
  • or replace the note to indicate that horizontal stretching was used.

@cconcolato cconcolato reopened this Oct 22, 2019
@skynavga
Copy link
Collaborator

skynavga commented Oct 31, 2019

It is not the intent of the note to precisely prescribe the rendering behavior. In fact, being overly prescriptive is undesirable. The only thing the note needs to impart is that "something" having to do with "half width" is applied to "some" glyphs in order to make the text fit in the EM box. All else is a detail of the implementation. So, I would oppose any attempt to further tweak this language or example.

@skynavga
Copy link
Collaborator

skynavga commented Nov 5, 2019

Propose this be re-closed without further action given the original commenter approved the already approved (and merged) PR (#1180).

@css-meeting-bot
Copy link
Member

The Timed Text Working Group just discussed Text Combine example is incorrect/misleading. ttml2#1128, and agreed to the following:

  • SUMMARY: @skynavga to remove reference to "half width" for this example.
The full IRC log of that discussion <nigel> Topic: Text Combine example is incorrect/misleading. ttml2#1128
<nigel> github: https://github.com//issues/1128
<nigel> Nigel: Looks like there's a collective desire for the image in the example and the text to match each other and show something useful?
<nigel> Cyril: Yes. I don't mind the text being vague, but at the moment it is wrong because it isn't showing what is happening at all.
<nigel> Glenn: I disagree with that.
<nigel> Cyril: It only talks about half-width variants but none are selected in the example.
<nigel> Glenn: It does have them.
<nigel> .. The AB34 on the right side are half width variants.
<nigel> Cyril: Unless the image has changed they are quarter width, right?
<nigel> Nigel: The "AB34" look like they're in one EM square width and heightwise.
<nigel> Cyril: Yes, so they're not half width variants but quarter width.
<nigel> Glenn: [thinks] Maybe we should remove the term "half width" entirely.
<nigel> Cyril: Yes, that's one option.
<nigel> Glenn: That I think is problematic. I could go back and remove that.
<nigel> Cyril: Great, that's all I'm asking.
<nigel> Glenn: Would you be ok with that Pierre?
<nigel> Pierre: I'm happy with whatever Cyril is happy with!
<nigel> SUMMARY: @skynavga to remove reference to "half width" for this example.

@skynavga
Copy link
Collaborator

skynavga commented Nov 7, 2019

I addressed #1128 (comment) in #1187 by retaining reference to half-width variants but indicating that it was a scaled form thereof. I hope this will suffice, as it is still desirable to refer to half-width variants given the prose

At a minimum, an implementation that supports this style property must be able to select half-width variant forms if available.

@skynavga skynavga added pr open and removed pr merged labels Nov 7, 2019
@skynavga skynavga changed the title Text Combine example is incorrect/misleading. Text combine example is incorrect/misleading. Nov 8, 2019
@skynavga skynavga added pr merged and removed pr open labels Nov 9, 2019
@skynavga skynavga removed their assignment Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment