Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes document references unmerged pull request. #1183

Closed
nigelmegitt opened this issue Oct 16, 2019 · 0 comments · Fixed by #1186
Closed

Changes document references unmerged pull request. #1183

nigelmegitt opened this issue Oct 16, 2019 · 0 comments · Fixed by #1186
Labels
no spec change pr merged
Milestone
2ED-CR

Comments

@nigelmegitt
Copy link
Contributor

The changes document currently includes:

However this was closed without merging based on a group decision, so the entry should be removed. I checked all the other entries, and they point to pull requests that were merged. I did not cross check that all merged pull requests are reflected in the changes document.
@skynavga skynavga changed the title Changes document references unmerged pull request Changes document references unmerged pull request. Nov 6, 2019
skynavga added a commit that referenced this issue Nov 6, 2019
@skynavga
Remove entry referring to unmerged PR #1146 (#1183).
27dd8d8
@skynavga skynavga mentioned this issue Nov 6, 2019
Merged
@skynavga skynavga self-assigned this Nov 6, 2019
@skynavga skynavga added this to the 2ED-CR milestone Nov 6, 2019
skynavga added a commit that referenced this issue Nov 6, 2019
@skynavga
Merge pull request #1186 from w3c/issue-1183-invalid-change-doc-entry
25ba3cc 
Remove entry referring to unmerged PR #1146 (#1183).
@skynavga skynavga removed their assignment Nov 6, 2019
@skynavga skynavga added pr merged and removed pr open labels Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
no spec change pr merged
Projects
None yet
Milestone
2ED-CR
Development

Successfully merging a pull request may close this issue.

Remove entry referring to unmerged PR #1146 (#1183). w3c/ttml2
2 participants
@skynavga @nigelmegitt