Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in HLG HDR appendix step 8 #397

Closed
nigelmegitt opened this issue Jul 6, 2017 · 6 comments
Closed

Error in HLG HDR appendix step 8 #397

nigelmegitt opened this issue Jul 6, 2017 · 6 comments

Comments

@nigelmegitt
Copy link
Contributor

Step 8 of appendix Q.2 Hybrid Log-Gamma HDR currently says (third line):

and b = 1−4a and c = 0.5−a•ln(4a)5b

The superscript 5b at the end is a transcription error from BT.2100, in which the 5b is a footnote reference (in an equation!).

The line should be:

and b = 1−4a and c = 0.5−a•ln(4a)

i.e. the superscript 5b needs to be removed.

@nigelmegitt nigelmegitt added the bug label Jul 6, 2017
@nigelmegitt nigelmegitt self-assigned this Jul 6, 2017
nigelmegitt added a commit that referenced this issue Jul 6, 2017
Fixes #397 by removing the erroneous 5b superscript.

Also took the opportunity to add fragment IDs to the appendix
subsections for easier linking.
@nigelmegitt
Copy link
Contributor Author

Here is the updated submission document to the one attached previously at #233 (comment) with the bug fixed there too:

SimpleConversion_sRGBtoHLG.pdf

@nigelmegitt
Copy link
Contributor Author

An additional point here is that in step 8 the line above the one highlighted in the issue is confusing:

where HLG(x) = (3x)0.5 if 0 ≤ x ≤ 1/12 or HLG(x) = a•ln(12x−b)+c if x > 1/12 and a = 0.17883277

This would be clearer if the "if"s the "and"s and the "or"s were separated out better.

@nigelmegitt
Copy link
Contributor Author

The same issue arises for step 11:

where clamp(x) = x if 0 ≤ x ≤ 1023 or 0 if x < 0 or 1023 if x > 1023

@nigelmegitt
Copy link
Contributor Author

I see that we have non-aligned syntaxes for the definitions of clamp in Q.1 and Q.2; also the formatting in Q.1 doesn't use preformatted blocks for the mathematical expressions, which it should to be aligned. Will throw fixes for that into the PR too.

@nigelmegitt
Copy link
Contributor Author

PR #398 updated to address the above three additional comments.

@nigelmegitt nigelmegitt modified the milestone: Editor's WR Work List Jul 18, 2017
@skynavga skynavga modified the milestones: Editor's WR Work List, Editor's CR Work List Aug 21, 2017
skynavga added a commit that referenced this issue Aug 21, 2017
Remove HLG HDR step 8 superscript 5b. See #397.
@css-meeting-bot
Copy link
Member

The Working Group just discussed ttml2#397 Error in HLG HDR appendix step 8.

The full IRC log of that discussion <nigel> Topic: ttml2#397 Error in HLG HDR appendix step 8
<nigel> github: https://github.com//issues/397
<nigel> Glenn: I merged #398 without any changes except to remove the HTML generated version.
<nigel> Nigel: Thank you, I always include that for easier previewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants