Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'available' keyword value for <measure> expression (#1004). #1005

Merged
merged 2 commits into from
Sep 25, 2018
Merged

Remove 'available' keyword value for <measure> expression (#1004). #1005

merged 2 commits into from
Sep 25, 2018

Conversation

skynavga
Copy link
Collaborator

Closes #1004.

@skynavga skynavga added this to the PR milestone Sep 23, 2018
@skynavga skynavga self-assigned this Sep 23, 2018
@palemieux
Copy link
Contributor

Built at https://rawgit.com/w3c/ttml2/issue-1004-measure-available-build/index.html

palemieux
palemieux approved these changes Sep 23, 2018
View reviewed changes
Copy link
Contributor

@palemieux palemieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TTPE is the only implementation that expressed interest in implementing available AFAIK, so removing the feature makes sense if TTPE will not implement it after all.

nigelmegitt
nigelmegitt approved these changes Sep 24, 2018
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as a change to PR version on the basis that in CR3 both #ipd and #bpd were marked as at-risk and this change directly affects those two features.

@skynavga
Copy link
Collaborator Author

@nigelmegitt for the record, note that <measure> is used by three features, #ipd, #bpd, and #extent-measure as well, and all of these are marked as at risk in CR3, so I think we are covered to remove it

@nigelmegitt
Copy link
Contributor

@skynavga re #1005 (comment) thank you for listing those.

@skynavga skynavga merged commit 56d3a5f into master Sep 25, 2018
@skynavga skynavga removed their assignment Sep 25, 2018
@skynavga
Copy link
Collaborator Author

Merged early for PR processing. Do not expect any further comments on this pull request/issue.

@skynavga skynavga deleted the issue-1004-measure-available branch October 4, 2018 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palemieux palemieux palemieux approved these changes

@nigelmegitt nigelmegitt nigelmegitt approved these changes

Assignees
No one assigned
Labels
pr merged early substantive
Projects
None yet
Milestone
1ED-PR
Development

Successfully merging this pull request may close these issues.
3 participants
@skynavga @palemieux @nigelmegitt