-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify relative profile designator does not use xml:base (#1033). #1054
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine as far as it goes, but I've noted in the issue that we need to apply a similar treatment to <fragment-profile-designator>
as well, or better yet, remove it since it seems to serve no purpose.
@nigelmegitt re: #1054 (review), please file a new issue so we can proceed with this PR; by the way, I believe you are wrong about not needing |
I'm really confused by your take on this @skynavga - are you saying that |
The Timed Text Working Group just discussed The full IRC log of that discussion<nigel> Topic: Clarify relative profile designator does not use xml:base (#1033). ttml2#1054<nigel> github: https://github.com//pull/1054 <cyril> nigel: the reason you are working on it is because you think changes are needed <cyril> glenn: yes, I'll have an update before the next meeting <cyril> nigel: is it worth sharing your initial thoughts <cyril> glenn: no <cyril> glenn: I'll reach out to you separately if I need |
spec/ttml2.xml
Outdated
@@ -6976,8 +6976,13 @@ the TT Profile Namespace, which serves as the base URI with which relative profi | |||
</tr> | |||
</tbody> | |||
</table> | |||
<note role="clarification"> | |||
<p>When absolutizing a <relative-profile-designator>, | |||
<loc href="#content-attribute-xml-base">xml:base</loc> processing does not apply (because the TT Profile Namespace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RFC 3986 does not define "absolutizing". I think you might mean "resolving a reference as defined in RFC 3986".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The term "absolutize", or a derivative of it, is used 9 times in TTML2. This is probably worth opening a separate editorial issue for, @palemieux .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@palemieux in the interests of moving this on, would it be okay for you to open a separate issue about the term "absolutize" used in relation to URLs, as I suggested at https://github.com/w3c/ttml2/pull/1054/files#r309211829 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nigelmegitt Sure. @skynavga or you should open an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raised #1150. @palemieux please could you re-review on this basis?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spec/ttml2.xml
Outdated
@@ -6976,8 +6976,13 @@ the TT Profile Namespace, which serves as the base URI with which relative profi | |||
</tr> | |||
</tbody> | |||
</table> | |||
<note role="clarification"> | |||
<p>When absolutizing a <relative-profile-designator>, | |||
<loc href="#content-attribute-xml-base">xml:base</loc> processing does not apply (because the TT Profile Namespace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The term "absolutize", or a derivative of it, is used 9 times in TTML2. This is probably worth opening a separate editorial issue for, @palemieux .
Hold pending merger of #1151. |
…-profile-designator
Closes #1033.