Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link for temporally active region reference (#1074). #1095

Merged
merged 1 commit into from
Jun 10, 2019
Merged

Add link for temporally active region reference (#1074). #1095

merged 1 commit into from
Jun 10, 2019

Conversation

skynavga
Copy link
Collaborator

Closes #1074.

@skynavga skynavga added this to the 2ED-FPWD milestone May 25, 2019
@skynavga skynavga requested a review from nigelmegitt May 25, 2019 20:14
@skynavga skynavga self-assigned this May 25, 2019
nigelmegitt
nigelmegitt approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

palemieux
palemieux previously requested changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@palemieux palemieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes on all PRs to prevent their closing before 14-day windows

@skynavga skynavga dismissed palemieux’s stale review June 7, 2019 15:36

This is not a legitimate request that you can apply unilaterally to block accepted protocol. If you can indicate why more time is need for a specific PR, then you can do so; however, I will not merely accept blockers because you don't like the existing protocol.

@skynavga skynavga merged commit 3da57bb into master Jun 10, 2019
@skynavga skynavga removed their assignment Jun 10, 2019
@skynavga skynavga deleted the issue-1074-temporally-active-region branch June 10, 2019 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cconcolato cconcolato cconcolato approved these changes

@nigelmegitt nigelmegitt nigelmegitt approved these changes

@palemieux palemieux palemieux left review comments

Assignees
No one assigned
Labels
editorial
Projects
None yet
Milestone
2ED-CR
Development

Successfully merging this pull request may close these issues.

Defined term temporally active region not cross-linked.
4 participants
@skynavga @cconcolato @palemieux @nigelmegitt