Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define significant text node, text node, and element node (#1105). #1107

Merged
merged 4 commits into from
Jun 7, 2019
Merged

Define significant text node, text node, and element node (#1105). #1107

merged 4 commits into from
Jun 7, 2019

Conversation

skynavga
Copy link
Collaborator

Closes #1105.

@skynavga skynavga added this to the 2ED-FPWD milestone May 31, 2019
@skynavga skynavga self-assigned this May 31, 2019
nigelmegitt
nigelmegitt approved these changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of logical nits, but looks good to me overall.

spec/ttml2.xml Show resolved Hide resolved
spec/ttml2.xml Show resolved Hide resolved
@skynavga skynavga mentioned this pull request Jun 3, 2019
Merged
@skynavga skynavga requested a review from nigelmegitt June 5, 2019 16:45
@skynavga skynavga added the agenda label Jun 5, 2019
@skynavga
Copy link
Collaborator Author

skynavga commented Jun 6, 2019

@nigelmegitt please verify and (re)approve (post resolving your comments)

@skynavga skynavga mentioned this pull request Jun 6, 2019
Closed
@skynavga skynavga added agenda and removed agenda labels Jun 6, 2019
@nigelmegitt
Copy link
Contributor

@skynavga Thanks for checking - my approval is still valid.

@skynavga
Copy link
Collaborator Author

skynavga commented Jun 7, 2019

Merging early as this change is editorial only.

@skynavga skynavga merged commit 92c468c into master Jun 7, 2019
@skynavga skynavga removed their assignment Jun 7, 2019
@skynavga skynavga deleted the issue-1105-significant-text-node branch June 10, 2019 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cconcolato cconcolato Awaiting requested review from cconcolato

@palemieux palemieux Awaiting requested review from palemieux

@nigelmegitt nigelmegitt Awaiting requested review from nigelmegitt

Assignees
No one assigned
Labels
editorial pr merged early
Projects
None yet
Milestone
2ED-CR
Development

Successfully merging this pull request may close these issues.

Clarify meaning of significant text node.
2 participants
@skynavga @nigelmegitt