Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1204 positioning example #1207

Merged
merged 7 commits into from
Jul 26, 2020
Merged

Issue 1204 positioning example #1207

merged 7 commits into from
Jul 26, 2020

Commits on Apr 16, 2020

  1. Move region specification in example to div 

    This is the first proposal in #1204.
    @nigelmegitt
    nigelmegitt committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    142e548 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2020

  1. Address feedback and add a new example document 

    During w3c/ttwg#107 @skynavga objected to moving the region specification in the last example from the `body` element to the `div` element and instead suggested adding an explanatory note.

This commit does that, and also adds a further example document showing content in two regions, overlapping temporally. The sample renderings are generated by sandflow/imscJS based on the source at `spec/images/sources/example-complex-layout.ttml` - this source necessarily includes both `tts:origin` and `tts:position` because that library currently does not support `tts:position` (since it is not part of IMSC).
    @nigelmegitt
    nigelmegitt committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    529d1e9 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2020

  1. Remove trailing white space 

    Resolves @cconcolato 's review comment.
    @nigelmegitt
    nigelmegitt authored Apr 30, 2020
    Configuration menu
    Copy the full SHA
    6154c1e View commit details
    Browse the repository at this point in the history

Commits on May 12, 2020

  1. Reduce width to keep in line with the rest of the spec.

    @nigelmegitt
    nigelmegitt committed May 12, 2020
    Configuration menu
    Copy the full SHA
    678bda3 View commit details
    Browse the repository at this point in the history

  2. Reduce verbosity to try to address review comments

    @nigelmegitt
    nigelmegitt committed May 12, 2020
    Configuration menu
    Copy the full SHA
    d371598 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2020

  1. Address @skynavga review comments

    @nigelmegitt
    nigelmegitt committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    21e4993 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2020

  1. Tweak section structure, add preamble paragraph.

    @skynavga
    skynavga committed Jul 26, 2020
    Configuration menu
    Copy the full SHA
    bd40140 View commit details
    Browse the repository at this point in the history