Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 0216 fontsize em on region #242

Merged
merged 4 commits into from
Feb 22, 2017
Merged

Conversation

skynavga
Copy link
Collaborator

@skynavga skynavga commented Feb 10, 2017

spec/ttml2.xml Outdated
<td>if not <loc href="#content-vocabulary-span"><el>region</el></loc> element,
then relative to parent element's font size; otherwise, relative to the
<td>if not <loc href="#document-structure-vocabulary-tt"><el>tt</el></loc> element,
then relative to nearest styled ancestor element's computed font size; otherwise, relative to the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If fontSize="100%" is specified on region alone, then

  • in TTML1, fontSize on the region is computed to be "1c"
  • in TTML2, fontSize on the region would be computed to 100% of nearest styled ancestor element's computed font size

What is a styled element?

@skynavga
Copy link
Collaborator Author

skynavga commented Feb 10, 2017 via email

@palemieux
Copy link
Contributor

I needed a term that would apply to tt but not to layout or head, since styles cannot be specified on them.

Since styles are computed after ISD construction, where regions can be made children of tt, thereby removing the need to create new terminology.

@skynavga
Copy link
Collaborator Author

skynavga commented Feb 11, 2017 via email

@skynavga
Copy link
Collaborator Author

skynavga commented Feb 17, 2017

To elaborate on [1]:

Since styles are computed after ISD construction, where regions can be made children of tt, thereby removing the need to create new terminology.

Incorrect.

ISD construction flattens styles as far as possible, including resolution of computed styles values. Only in some special circumstances, namely, those where the resolution of a computed style requires that layout occur or requires access to presentation time state, is it the case that styles are computed after ISD construction.

[1] #242 (comment)

Copy link
Collaborator Author

@skynavga skynavga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding definition of styled element.

@skynavga skynavga merged commit 8abbce4 into gh-pages Feb 22, 2017
@skynavga skynavga deleted the issue-0216-fontsize-em-on-region branch August 21, 2017 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants