Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #298 sRGB on HLG #299

Merged
merged 7 commits into from
May 2, 2017
Merged

Issue #298 sRGB on HLG #299

merged 7 commits into from
May 2, 2017

Conversation

nigelmegitt
Copy link
Contributor

@nigelmegitt nigelmegitt commented Apr 25, 2017

Resolve #298 by moving the existing Appendix P PQ section to a sub-section and adding a new sub-section for HLG.

* Move PQ compositing into a sub-section of appendix P and add HLG as a
second sub-section
* Make links back to `tts:luminanceGain` attributes clickable.
* Fix copy/paste error by adding back ≤ characters.
* Put expressions in code blocks.
* Fix validation errors.
Use full names rather than abbreviations.
@nigelmegitt nigelmegitt changed the title Issue #233 sRGB on HLG Issue #298 sRGB on HLG Apr 25, 2017
@nigelmegitt nigelmegitt added this to the TTML2WR milestone Apr 25, 2017
@nigelmegitt
Copy link
Contributor Author

Please note that the branch name for this pull request was derived from the originating #233 before I split the new issue out, hence the slightly confusing naming.

Appendix P.2 note augmented to mention mapping of peak white.
@nigelmegitt
Copy link
Contributor Author

I plan to add an informative CIE XYZ reference when I can confirm the correct citation.

@nigelmegitt
Copy link
Contributor Author

Informative reference to CIE XYZ now added, I think this is good to review please.

@nigelmegitt
Copy link
Contributor Author

Notes from meeting 2017-04-27: Following merge of #294 need to merge those changes in and resolve conflicts (@nigelmegitt to do). Request was made by @skynavga to modify the CIE XYZ reference to align it better with other ISO references and change the key to just [XYZ] for conciseness.

# Conflicts:
#	spec/ttml2.html
#	spec/ttml2.xml

Additionally resolve comment from @skynavga about the XYZ reference,
changing key to just `XYZ` and updating the reference style in the
Other References section.
@nigelmegitt
Copy link
Contributor Author

#299 (comment) addressed in d7ca266 - this can now be reviewed again please @skynavga and @palemieux (and anyone else).

@skynavga
Copy link
Collaborator

skynavga commented May 2, 2017

Merging after 3 days have passed from last commit without further comment.

@skynavga skynavga merged commit 82357c4 into gh-pages May 2, 2017
@skynavga skynavga deleted the issue-0233-srgb-on-hlg branch August 21, 2017 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants