Issue 0219 text decoration inheritance #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigelmegitt
previously requested changes
May 15, 2017
spec/ttml2.xml
Outdated
| be inherited separately from the others.</p> | ||
| <note role="example"> | ||
| <p>For example, if the computed value of <code>tts:textDecoration</code> that applies to a <code>div</code> (division) element | ||
| is the tuple <code>(false, true, true)</code>, denoting <code>(noUnderline, lineThrough, overline)</code>, and a |
There was a problem hiding this comment.
I don't think the use of booleans helps this example for comprehensibility. Why not just use (noUnderline, lineThrough, overline) directly and remove the (false, true, true) equivalent? That boolean equivalent is not defined anywhere.
There was a problem hiding this comment.
Accepted, will change.
…erence to boolean values (#219).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #219.