Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 0164 default play rate #324

Merged
merged 4 commits into from
May 24, 2017
Merged

Conversation

skynavga
Copy link
Collaborator

Closes #164.

spec/ttml2.xml Outdated
<note role="elaboration">
<p>If the value of <code>playRate</code> is determined by the <loc href="#terms-document-processing-context">document processing context</loc>,
i.e., it is not set to the default value of <code>1.0</code>, then that value may vary in real time over the course of document
presentation, in which case future values of <code>R</code> for given values of <code>M</code> are expected to be re-evaluated based on new
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word "future" here may be misleading - I suggest removing it. It does not account for the fact that the play rate may be set to a negative value by the processing context, e.g. by the user pressing "rewind".

Copy link
Collaborator Author

@skynavga skynavga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, future means not yet come to pass, which covers both forward and reverse play rates; however, I will remove the word as you requested.

@skynavga skynavga dismissed nigelmegitt’s stale review May 23, 2017 15:18

Comment addressed.

Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me.

Incidentally, you don't need to dismiss my review - I am happy to re-review and approve.

@skynavga skynavga merged commit 9c7a204 into gh-pages May 24, 2017
@skynavga skynavga deleted the issue-0164-default-play-rate branch August 21, 2017 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants