Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 0164 default play rate #324

Merged
merged 4 commits into from May 24, 2017

Conversation

Projects
None yet
2 participants
@skynavga
Copy link
Collaborator

commented May 22, 2017

Closes #164.

@skynavga skynavga requested a review from nigelmegitt May 22, 2017

@skynavga skynavga added the for review label May 22, 2017

<note role="elaboration">
<p>If the value of <code>playRate</code> is determined by the <loc href="#terms-document-processing-context">document processing context</loc>,
i.e., it is not set to the default value of <code>1.0</code>, then that value may vary in real time over the course of document
presentation, in which case future values of <code>R</code> for given values of <code>M</code> are expected to be re-evaluated based on new

This comment has been minimized.

Copy link
@nigelmegitt

nigelmegitt May 23, 2017

Contributor

The word "future" here may be misleading - I suggest removing it. It does not account for the fact that the play rate may be set to a negative value by the processing context, e.g. by the user pressing "rewind".

@skynavga
Copy link
Collaborator Author

left a comment

In this case, future means not yet come to pass, which covers both forward and reverse play rates; however, I will remove the word as you requested.

Comment addressed.

@nigelmegitt
Copy link
Contributor

left a comment

Thank you, looks good to me.

Incidentally, you don't need to dismiss my review - I am happy to re-review and approve.

@skynavga skynavga merged commit 9c7a204 into gh-pages May 24, 2017

1 check passed

ipr PR deemed acceptable.
Details

@skynavga skynavga deleted the issue-0164-default-play-rate branch Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.