Issue 0221 writing mode and direction #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palemieux
reviewed
May 26, 2017
| <div4 id="style-attribute-direction-special-semantics"> | ||
| <head>Special Semantics</head> | ||
| <p>When performing style resolution processing (see <specref ref="semantics-style-resolution-processing"/>), | ||
| the resolution of the computed value of <att>tts:direction</att> on a <loc href="#layout-vocabulary-region"><el>region</el></loc> element |
There was a problem hiding this comment.
even though it applies to region only, tts:writingMode can be specified on any element, so this should read on an element instead of region element.
|
On Fri, May 26, 2017 at 1:52 PM, Pierre-Anthony Lemieux < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In spec/ttml2.xml
<#338 (comment)>:
> @@ -8834,6 +8834,26 @@ The title of the book is
represented by this attribute are based upon that defined by <bibref ref="xsl11"/>,
§ 7.29.1.</p>
</note>
+<div4 id="style-attribute-direction-special-semantics">
+<head>Special Semantics</head>
+<p>When performing style resolution processing (see <specref ref="semantics-style-resolution-processing"/>),
+the resolution of the computed value of <att>tts:direction</att> on a <loc href="#layout-vocabulary-region"><el>region</el></loc> element
even though it applies to region only, tts:writingMode can be specified
on any element, so this should read *on an element* instead of *region
element*.
No. See my immediately previous comment. tts:writingMode would be ignore in
that context: it doesn't apply and isn't inherited.
… —
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#338 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAXCb45XYn9c7LwkUUbT-umMdwOZq38Aks5r9y2HgaJpZM4Nn0hA>
.
|
Can you point to the provisions that state this? |
|
On Fri, May 26, 2017 at 1:58 PM, Pierre-Anthony Lemieux < ***@***.***> wrote:
No. See my immediately previous comment. tts:writingMode would be ignore in
that context: it doesn't apply and isn't inherited.
Can you point to the provisions that state this?
Are you asking what "applies to" means? I would think it obvious, as
indicated by the title of your issue #213:
Avoid populating non-applicable, non-inheritable styles in SSS(E)
"Applies to" is used in TTML (and XSL-FO) in the common English sense of
"is used with or on", etc., Its negation means it "is not used with or on"
meaning "is ignored" for the purpose of ascribing some characteristic or
behavior.
But if your are asking for textual evidence, I see the following in XSL-FO:
The first step in refinement of a particular formatting object is to obtain
the effective value of each property that applies to the object.
Note that TTML, having been based on XSL-FO semantics, draws widely from
the language used there. For example, in [1], which enumerates which
elements each property "applies to". The same terminology is used in CSS.
[1] https://www.w3.org/TR/xsl/#prapply
Frankly, I am a little surprised by your question.
… —
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#338 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAXCbw6grVME8EeGajG0EXklhYKGa3Qxks5r9y8DgaJpZM4Nn0hA>
.
|
|
On Fri, May 26, 2017 at 2:51 PM, Glenn Adams ***@***.***> wrote:
On Fri, May 26, 2017 at 1:58 PM, Pierre-Anthony Lemieux <
***@***.***> wrote:
> No. See my immediately previous comment. tts:writingMode would be ignore
> in
> that context: it doesn't apply and isn't inherited.
>
> Can you point to the provisions that state this?
>
Are you asking what "applies to" means? I would think it obvious, as
indicated by the title of your issue #213:
Avoid populating non-applicable, non-inheritable styles in SSS(E)
See also my comment
#213 (comment). I have just
started working
on a resolution of this issue (#213), so I will go out of my way to make it
clear that if a property does not apply to an element and if it is not
inheritable, then if it is specified on that element, it is ignored and not
populated into SSS(E).
…
"Applies to" is used in TTML (and XSL-FO) in the common English sense of
"is used with or on", etc., Its negation means it "is not used with or on"
meaning "is ignored" for the purpose of ascribing some characteristic or
behavior.
But if your are asking for textual evidence, I see the following in XSL-FO:
The first step in refinement of a particular formatting object is to
> obtain the effective value of each property that applies to the object.
Note that TTML, having been based on XSL-FO semantics, draws widely from
the language used there. For example, in [1], which enumerates which
elements each property "applies to". The same terminology is used in CSS.
[1] https://www.w3.org/TR/xsl/#prapply
Frankly, I am a little surprised by your question.
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#338 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AAXCbw6grVME8EeGajG0EXklhYKGa3Qxks5r9y8DgaJpZM4Nn0hA>
> .
>
|
|
On Fri, May 26, 2017 at 3:43 PM, Pierre-Anthony Lemieux < ***@***.***> wrote:
so I will go out of my way to make it
clear that if a property does not apply to an element and if it is not
inheritable, then if it is specified on that element, it is ignored and not
populated into SSS(E).
That is not the right solution since it changes the style resolution rules.
It is much simpler to simply state that the exception applies to all
elements.
I will give this some thought. It would definitely be the wrong approach to
call out tts:writingMode specifically in any such language that clarifies
what the negation of "applies to" means.
… —
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#338 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAXCb4VozpLyj2FOi9Qw3koKwDrU-ZbHks5r90eBgaJpZM4Nn0hA>
.
|
Yes -- I had actually deleted my comment since addressing #213 might clarify this :) Regardless of the disposition of #213, it might be safer to extend the special resolution semantics of |
|
On Fri, May 26, 2017 at 4:29 PM, Pierre-Anthony Lemieux < ***@***.***> wrote:
It would definitely be the wrong approach to
call out tts:writingMode specifically in any such language that clarifies
what the negation of "applies to" means.
Yes -- I had actually deleted my comment since addressing #213
<#213> might clarify this :)
Regardless of the disposition of #213
<#213>, it might be safer to extend
the special resolution semantics of tts:direction + tts:writingMode to
all elements (I do not see how it can hurt).
ok, i'll consider it and do so if it doesn't conflict with general language
to handle #213
… —
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#338 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAXCb9fL6XrOARIZxgX8FebAeCfL-oMEks5r91IsgaJpZM4Nn0hA>
.
|
#213 is specifically about "Initial values of non-inheritable styles should not be applied to elements to which the style does not apply." It did not consider specified but non-applicable and non-inheritable styles. I would very careful with changing the core style resolution algorithm to ignore specified but non-applicable and non-inheritable styles given the inter-dependencies of some style attributes. I was happy with this PR, and was just asking to extend the special resolution semantics of tts:direction + tts:writingMode to all elements (I do not see how it can hurt). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #221.