Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 0215 extent auto #348

Merged
merged 3 commits into from
Jun 3, 2017
Merged

Issue 0215 extent auto #348

merged 3 commits into from
Jun 3, 2017

Conversation

skynavga
Copy link
Collaborator

Closes #215.

Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this as it stands but it does not close #215, since it does not address:

  • The available measure specifies inner size excluding border and padding, whereas for region we want outer size including border and padding.

That could be raised as a separate issue, and this merged, or we could just deal with it here.

@skynavga
Copy link
Collaborator Author

skynavga commented May 31, 2017 via email

@nigelmegitt
Copy link
Contributor

OK I've raised #351 on the subsidiary point.

Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having raised #351, I can now approve this pull request.

@skynavga skynavga closed this Jun 3, 2017
@skynavga skynavga reopened this Jun 3, 2017
@skynavga skynavga merged commit 1554e66 into gh-pages Jun 3, 2017
@skynavga skynavga deleted the issue-0215-extent-auto branch August 21, 2017 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants