-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 0215 extent auto #348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this as it stands but it does not close #215, since it does not address:
- The available measure specifies inner size excluding border and padding, whereas for
region
we want outer size including border and padding.
That could be raised as a separate issue, and this merged, or we could just deal with it here.
That's a different (new) issue, unrelated to this one.
…On Wed, May 31, 2017 at 1:58 AM, Nigel Megitt ***@***.***> wrote:
***@***.**** commented on this pull request.
I'm happy with this as it stands but it does not close #215
<#215>, since it does not address:
- The *available* measure specifies inner size excluding border and
padding, whereas for region we want outer size including border and
padding.
That could be raised as a separate issue, and this merged, or we could
just deal with it here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#348 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAXCb29XRNISZrD19oBiaM0ey9NuZzScks5r_R2ogaJpZM4Nq5q5>
.
|
OK I've raised #351 on the subsidiary point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having raised #351, I can now approve this pull request.
Closes #215.