Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coalesce references to URI syntax into a new <uri> value expression (… #488

Merged
merged 6 commits into from
Dec 22, 2017
Merged

Coalesce references to URI syntax into a new <uri> value expression (… #488

merged 6 commits into from
Dec 22, 2017

Conversation

skynavga
Copy link
Collaborator

@skynavga skynavga commented Nov 9, 2017

…#474).

Closes #474.

@skynavga skynavga added this to the Editor's CR Work List milestone Nov 9, 2017
nigelmegitt
nigelmegitt reviewed Nov 17, 2017
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as far as it goes, and is editorial.

However it does not include the fix to the URI reference, as proposed at #474 (comment) (or an equivalent).

@nigelmegitt nigelmegitt changed the base branch from gh-pages to master December 15, 2017 22:22
@nigelmegitt
Copy link
Contributor

@skynavga please could you merge from master so this is up to date with the new build process?

@nigelmegitt
Copy link
Contributor

Also, the pull request shouldn't include spec/ttml2.html since that is now a transient build artefact.

@skynavga skynavga self-assigned this Dec 22, 2017
@skynavga
Copy link
Collaborator Author

@nigelmegitt regarding the request to change the normative reference for [URI] from RFC2396 to RFC3986, I am not comfortable making this change in the context of this issue, as it may have wider ramifications; can you accept this PR as is and file another issue if you want to upgrade the [URI] reference? The references in this PR are synchronized with 2396 section numbering, and not 3986.

nigelmegitt
nigelmegitt approved these changes Dec 22, 2017
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, happy to move the change of URI reference to another issue. Approving.

@skynavga skynavga merged commit 51d8c43 into master Dec 22, 2017
@skynavga skynavga removed their assignment Dec 22, 2017
@skynavga skynavga deleted the issue-0474-uri-references branch March 9, 2018 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nigelmegitt nigelmegitt nigelmegitt approved these changes

Assignees
No one assigned
Labels
editorial pr merged
Projects
None yet
Milestone
1ED-CR1
Development

Successfully merging this pull request may close these issues.
2 participants
@skynavga @nigelmegitt