Remove textAlign on span and mark inlineBlock, ipd and bpd at risk #563
Conversation
|
@cconcolato please could you link your W3C and github accounts together, at https://www.w3.org/users/myprofile/connectedaccounts ? This will clear the ipr issue on this and any other pull requests you make. |
spec/ttml2.xml
Outdated
| </tr> | ||
| </tbody> | ||
| </table> | ||
| <p></p> |
There was a problem hiding this comment.
The lines 12807-12815 should not be removed since they display the example rendering of the first example, which remains.
|
@cconcolato I see your accounts are now linked, and have revalidated this pull request for ipr, and it now passes. Thank you! |
|
@nigelmegitt sorry for this oversight. Fixed now. |
| <td>O</td> | ||
| <td>O</td> | ||
| </tr> | ||
| <tr> |
There was a problem hiding this comment.
Need to add entries to profiles/ttml2-*.xml.
There was a problem hiding this comment.
IIUC, the content of profiles/ttml2-.xml is processed to escape XML tags into profiles/ttml2-.xml.esc. And those files are imported in ttml2.xml as entities into Annex G. When I check profiles/ttml2-*.xml, the definitions of the feature designators (#textAlign-justify and #textAlign-version-2) are already in.
The problem is that ttml2.xml does duplicate that information in Table E-1, and there it was missing. That's what those changes are for. Is that clearer? Is there any other way to proceed?
There was a problem hiding this comment.
Thanks, that addresses my comment. Approving now.
|
Thanks @cconcolato that fixes the cutting issue - I'll wait until you've addressed @skynavga 's comments before re-reviewing. |
| <td>O</td> | ||
| <td>O</td> | ||
| </tr> | ||
| <tr> |
There was a problem hiding this comment.
Thanks, that addresses my comment. Approving now.
|
@nigelmegitt please approve |
Closes #238.