Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove root style inheritance (#546). #596

Merged
merged 3 commits into from
Feb 12, 2018
Merged

Remove root style inheritance (#546). #596

merged 3 commits into from
Feb 12, 2018

Conversation

skynavga
Copy link
Collaborator

Closes #546.

@skynavga skynavga self-assigned this Jan 29, 2018
@skynavga skynavga added this to the Editor's CR Work List milestone Jan 29, 2018
nigelmegitt
nigelmegitt reviewed Jan 29, 2018
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should §10.5.4.4 Style Resolution Process now omit tt from its list of elements to include? (I checked and it is not in the equivalent list in TTML1SE)

palemieux
palemieux requested changes Jan 30, 2018
View reviewed changes
Copy link
Contributor

@palemieux palemieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like ttml2-document.rnc needs to be modified according to 67c674e

@skynavga
Copy link
Collaborator Author

skynavga commented Feb 8, 2018

@nigelmegitt @palemieux addressed your comments in 8d29631

@skynavga
Copy link
Collaborator Author

skynavga commented Feb 9, 2018

@palemieux your comments have been addressed

nigelmegitt
nigelmegitt approved these changes Feb 9, 2018
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, my comments addressed.

@skynavga skynavga merged commit eb0cddb into master Feb 12, 2018
@skynavga skynavga removed their assignment Feb 12, 2018
@skynavga skynavga deleted the issue-0546-remove-root-style-inheritance branch March 9, 2018 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palemieux palemieux palemieux approved these changes

@nigelmegitt nigelmegitt nigelmegitt approved these changes

Assignees
No one assigned
Labels
substantive
Projects
None yet
Milestone
1ED-CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@skynavga @palemieux @nigelmegitt