Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note for wide ruby annotations (#250). #605

Merged
merged 6 commits into from
Feb 15, 2018

Conversation

cconcolato
Copy link
Contributor

closes #250

spec/ttml2.xml Outdated
@@ -11819,6 +11819,13 @@ have no impact on ruby alignment.</p>
</note>
<p>If a computed value of the property associated with this attribute is not supported,
then a <loc href="#terms-presentation-processor">presentation processor</loc> must use the value <code>auto</code>.</p>
<note role="elaboration">
<p>In this specification, ruby annotations in subtitling events are assumed to be narrow, so as to ease their reading. As a consequence,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not happy to reference subtitling events in TTML2. That's a specific usage and should be in IMSC. Rather, we should switch "subtitling events" for "timed text applications" and "so as to ease their reading" for "since presentation space and available time are often constrained" (happy for tweaks to be made to the precise wording)

@cconcolato
Copy link
Contributor Author

@nigelmegitt I've tweaked the wording. How does it read now? Can you approve?

@nigelmegitt
Copy link
Contributor

Thanks @cconcolato I don't have any problem with that text now, but there's no point in merging it unless it also helps with the issue - so @r12a please could you take a look at this and see if it addresses your issue?

I note that this specific proposal for a note was not mentioned in the issue. In fact the last comment, from June, is suggesting a change to the semantics of rubyAlign, rather than a note.

@nigelmegitt
Copy link
Contributor

Closing and reopening to trigger travis.

@nigelmegitt nigelmegitt closed this Feb 8, 2018
@nigelmegitt nigelmegitt reopened this Feb 8, 2018
@skynavga skynavga changed the title Add note for wide ruby annotations Add note for wide ruby annotations (#250). Feb 15, 2018
Copy link
Collaborator

@skynavga skynavga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed "in the base text" to avoid the wrong impression that insertion of space in base text is the only option, i.e., overlap is another option.

@skynavga
Copy link
Collaborator

@nigelmegitt I propose we merge the (now updated) note as an adequate response to the initial comment

@cconcolato cconcolato merged commit 5428743 into master Feb 15, 2018
@skynavga skynavga deleted the issue-0250-rubyAlign-wide branch March 9, 2018 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rubyAlign and wide ruby text
4 participants