Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pubrules errors and warnings (#684). #685

Merged
merged 8 commits into from
Mar 9, 2018
Merged

Conversation

skynavga
Copy link
Collaborator

@skynavga skynavga commented Mar 1, 2018

Closes #684.
Closes #686.

@skynavga skynavga added this to the CR1 milestone Mar 1, 2018
@skynavga skynavga self-assigned this Mar 1, 2018
@skynavga
Copy link
Collaborator Author

skynavga commented Mar 1, 2018

@nigelmegitt all pubrule errors have been addressed; please approve

Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The W3C Link Checker has found these broken fragment IDs:

error Lines: 720, 1568, 3924, 4700, 7153, 7156, 9425, 9428, 9848, 9850 https://rawgit.com/w3c/ttml2/issue-0684-pubrules-build/index.html
    Status: 200 OK

    Some of the links to this resource point to broken URI fragments (such as index.html#fragment). 
    Broken fragments:

        https://rawgit.com/w3c/ttml2/issue-0684-pubrules-build/index.html#weight-attribute-fontWeight (lines 9425, 9428)
        https://rawgit.com/w3c/ttml2/issue-0684-pubrules-build/index.html#document-layout-vocabulary-region (lines 4700, 7153, 7156)
        https://rawgit.com/w3c/ttml2/issue-0684-pubrules-build/index.html#document-layout-vocabulary-tt (line 3924)
        https://rawgit.com/w3c/ttml2/issue-0684-pubrules-build/index.html#content-attribute-conditionalization (line 1568)
        https://rawgit.com/w3c/ttml2/issue-0684-pubrules-build/index.html#style-attribute-rubyAlign-withBase (lines 9848, 9850)
        https://rawgit.com/w3c/ttml2/issue-0684-pubrules-build/index.html#semantics-procedure-construct-effective-validation-schema (line 720)

It also found permanent redirects that we should fix - many are just to do with rawgit, but the ones that are actually relevant are:

 Lines: 11781, 11786 http://www.ce.org/ redirected to https://www.cta.tech/
    Status: 301 -> 200 OK

    This is a permanent redirect. The link should be updated. 

warning Line: 8751 http://www.w3.org/wiki/TTML/RoleRegistry redirected to https://www.w3.org/wiki/TTML/RoleRegistry
    Status: 301 -> 200 OK

    This is a permanent redirect. The link should be updated. 

warning Lines: 11759, 11760 http://www.w3.org/TR/css3-fonts/ redirected to http://www.w3.org/TR/css-fonts-3/
    Status: 301 -> 200 OK

    This is a permanent redirect. The link should be updated. 

warning Line: 347 http://www.csail.mit.edu/ redirected to https://www.csail.mit.edu/
    Status: 301 -> 200 OK

    This is a permanent redirect. The link should be updated. 

Lines: 11750, 11751 http://www.w3.org/TR/css3-background/ redirected to http://www.w3.org/TR/css-backgrounds-3/
    Status: 301 -> 200 OK

    This is a permanent redirect. The link should be updated. 

 Line: 8764 http://www.w3.org/wiki/TTML/ItemNameRegistry redirected to https://www.w3.org/wiki/TTML/ItemNameRegistry
    Status: 301 -> 200 OK

    This is a permanent redirect. The link should be updated. 

 Lines: 11762, 11763 http://www.w3.org/TR/css3-break/ redirected to http://www.w3.org/TR/css-break-3/
    Status: 301 -> 200 OK

    This is a permanent redirect. The link should be updated. 

Line: 347 http://www.ercim.eu/ redirected to https://www.ercim.eu/
    Status: 301 -> 200 OK

    This is a permanent redirect. The link should be updated. 

Lines: 11614, 11617 http://www.gps.gov/technical/ redirected to https://www.gps.gov/technical/
    Status: 301 -> 200 OK

    This is a permanent redirect. The link should be updated. 

Lines: 11636, 11801, 11805, 11808 http://www.iso.org/ redirected to https://www.iso.org/home.html
    Status: 301 -> 200 OK

    This is a permanent redirect. The link should be updated. 

They don't cause a pubrules failure, but the pubrules checker strongly advises fixing them. Probably best just to fix here rather than open a separate issue.

spec/status.xml Outdated
Markup Language &versionOfTT; (TTML&versionOfTT;), and is intended to
be progressed to a W3C Recommendation. If you wish to make comments
regarding this document, please send them to <loc
href="mailto:public-tt@w3.org">public-tt@w3.org</loc> (<loc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also invite comments to be raised as issues directly on the ttml2 repo, with a link.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've raised that as #686.

@nigelmegitt
Copy link
Contributor

@skynavga @cconcolato I think this being unmerged and unresolved will prevent @plehegar or @tmichel07 from completing the transition request - are either of you able to make the fixes today please?

@skynavga
Copy link
Collaborator Author

skynavga commented Mar 6, 2018

@nigelmegitt @cconcolato I am working on this today but this will not prevent the transition request. Editorial changes are always permitted up to the instant of publishing.

@skynavga
Copy link
Collaborator Author

skynavga commented Mar 8, 2018

@nigelmegitt @cconcolato updated now, awaiting travis (very slow) to verify pubrules are happy

@nigelmegitt
Copy link
Contributor

nigelmegitt commented Mar 9, 2018

Passes pubrules and link checker now, thank you @skynavga ! (remaining task for @plehegar is to change index.html to Overview.html and do a final run-through as usual)

@skynavga skynavga merged commit a4edf34 into master Mar 9, 2018
@skynavga skynavga removed their assignment Mar 9, 2018
@skynavga skynavga deleted the issue-0684-pubrules branch March 9, 2018 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants