-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude implied animation of region via tts:origin on div and p (#710). #742
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting a change to the editorial formulation, and also noting that this change does not define #origin-block
as per #710 (comment).
spec/ttml2.xml
Outdated
@@ -20810,6 +20810,11 @@ attribute.</p> | |||
the <loc | |||
href="#style-attribute-origin"><att>tts:origin</att></loc> | |||
attribute.</p> | |||
<p>Notwithstanding the above, support for the <code>#origin</code> feature does not require support for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this formulation - it seems confusing to contradict the definition immediately after it. I would prefer to qualify the definition in the first place, for example by changing:
supports the
#origin
feature if it recognizes and is capable of transforming thetts:origin
attribute.
to:
supports the
#origin
feature if it recognizes and is capable of transforming thetts:origin
attribute as applied to theregion
element.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use the same formulation throughout in the same manner, so your suggestion would create an inconsistency. [I just counted 11 instances of this formulaic language in master.]
Closing without merge as the changes proposed here have been superseded by #794. |
Dismissing stale review; please re-review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Closes #710.
Note that
tts:origin
does not directly apply todiv
andp
; rather, it applies toregion
via an implicit redirection (of styles) ondiv
andp
.