Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qualify use of 'line area' (#749). #750

Merged
merged 3 commits into from
May 20, 2018
Merged

Conversation

skynavga
Copy link
Collaborator

Closes #749.

@skynavga skynavga added this to the CR2 milestone May 16, 2018
@skynavga skynavga self-assigned this May 16, 2018
@skynavga skynavga requested a review from palemieux May 16, 2018 06:19
Copy link
Contributor

@palemieux palemieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still unclear. Is it the last line of the Ruby Container, or the last line of the <p> or <div> or <region>, which can contain multiple Ruby Containers.

@skynavga
Copy link
Collaborator Author

@palemieux see new clarification attempt; note also that only the last block area generated by a paragraph contains a last line area; it is not well-formed to say the last line of a div or region; also, I removed the qualifier affected since the semantics here (whether equivalent to before or after) are not related to whether a line area is affected by (subjected to) an annontation

@palemieux
Copy link
Contributor

@skynavga Ok. This is much more precise. Why "the last block area" in "the last line area of the last block area"? Can a <p> contains multiple blocks in TTML2?

@skynavga
Copy link
Collaborator Author

@palemieux regarding

Can a <p> contains multiple blocks in TTML2?

In the general XSL formatting model yes, but, at present in TTML, no, since TTML doesn't have the concept of a page break (or region break). However, in the future, we could have a paragraph flow into a series of connected regions, in which last block area is pertinent.

Note also that the new language (here) matches the language already found in the note at the end of 10.2.39 tts:textAlign.

@palemieux
Copy link
Contributor

@nigelmegitt @skynavga This is not editorial, BTW

@skynavga
Copy link
Collaborator Author

@palemieux there is definitely no impact on conformance, so I would have to disagree; making a change to normative text, for example, to do a better job of explaining something already implied, does not mean it is a substantive change

@nigelmegitt
Copy link
Contributor

@nigelmegitt
Copy link
Contributor

@palemieux I think this is an editorial clarification, but it is one that is significant enough to warrant care and time to get it right and to invite reviews. @skynavga it would be inappropriate to merge this early.

Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is okay but have asked a question about the formulation.

<p>Equivalent to <code>before</code> for all but the last affected line area; otherwise, equivalent to <code>after</code>
for the last affected line area.</p>
<p>Equivalent to <code>before</code> for all but the last line area of the last block area generated by
a <loc href="#content-vocabulary-p"><el>p</el></loc> element which contains annotated text; otherwise, equivalent to <code>after</code>.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that <annotation-position> is only ever used as syntax for an attribute that applies to span elements. Should we be explicitly relating the p element mentioned here to the span on which the style attribute is applied?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? A span can only be a descendant of a unique p.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean to relate it to the particular p that the span is a descendant of, rather than any other p.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it cannot be interpreted as related to any other p, so what is the point in saying it. That would be like saying the impossible is impossible.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree that it cannot be interpreted as related to any other p @skynavga, but I'm not motivated to argue this.

@skynavga skynavga merged commit 9dce695 into master May 20, 2018
@skynavga skynavga removed their assignment May 20, 2018
@skynavga skynavga deleted the issue-0749-last-line-area branch June 28, 2018 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants