Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial improvement and typo fix for ruby constraints (#786, #787, … #795

Merged
merged 2 commits into from May 30, 2018
Merged

Editorial improvement and typo fix for ruby constraints (#786, #787, … #795

merged 2 commits into from May 30, 2018

Conversation

skynavga
Copy link
Collaborator

…#788).

Closes #786.
Closes #787.
Closes #788.

@skynavga skynavga added this to the CR2 milestone May 24, 2018
@skynavga skynavga self-assigned this May 24, 2018
@palemieux palemieux removed their request for review May 27, 2018 14:13
nigelmegitt
nigelmegitt approved these changes May 30, 2018
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much clearer than before and addresses all the issues it is supposed to. Thank you!

@cconcolato
Copy link
Contributor

Built version https://rawgit.com/w3c/ttml2/7a823a1dde0223104070248ec2ffbd2827c0ad6f/index.html#style-attribute-ruby

@skynavga skynavga merged commit a306209 into master May 30, 2018
@skynavga skynavga removed their assignment May 30, 2018
@spoeschel
Copy link

@skynavga
Thank you, this really improved the readability.

@skynavga skynavga deleted the issue-0786-ruby-constraints branch June 28, 2018 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cconcolato cconcolato cconcolato approved these changes

@nigelmegitt nigelmegitt nigelmegitt approved these changes

Assignees
No one assigned
Labels
editorial
Projects
None yet
Milestone
1ED-CR2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@skynavga @cconcolato @spoeschel @nigelmegitt