Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse language for style application to paragraph text nodes; add … #803

Merged
merged 4 commits into from
Jun 1, 2018

Conversation

skynavga
Copy link
Collaborator

…anonymous span term (#533).

Closes #533.

@skynavga skynavga added this to the CR2 milestone May 29, 2018
@skynavga skynavga self-assigned this May 29, 2018
@cconcolato
Copy link
Contributor

spec/ttml2.xml Outdated
@@ -7759,6 +7769,9 @@ unless explicitly permitted by an element type definition, an attribute in the <
should not be specified on an element unless it either applies to that element or denotes an inheritable style property.
If it does not apply to that element and does not denote an inheritable style property, then it must be ignored for the purpose
of non-validation processing. In the case of validation processing, such usage should be reported as a warning.</p>
<p>For the purpose of determining the applicability of a style property, if the style property is defined so as to apply to a
<loc href="#content-vocabulary-span"><el>span</el></loc> element, then it also applies to
<loc href="#terms-anonymous-span">anonymous span</loc> elements.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems obvious to me.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this because someone (perhaps you) had suggested that we add anonymous span to the Applies to entries for each property that listed span. I did not wish to add this in all those locations, so determined that a blanket statement in the prologue would serve the same purpose. Just consider the purpose of this text to be for avoidance of doubt, which we use elsewhere as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a helpful line to add to the spec, but I would prefer to explicitly state that character children of p elements are considered to be enclosed in those anonymous spans. Perhaps reword to:

For the purpose of determining the applicability of a style property, if the style property is defined 
so as to apply to a <loc href="#content-vocabulary-span"><el>span</el></loc> element, then it also 
applies to the <loc href="#terms-anonymous-span">anonymous span</loc> elements that enclose 
any character content children of <loc href="#content-vocabulary-"><el>p</el></loc> elements.

In a way this could be seen as duplication of the definition of anonymous span, but I think it would be helpful for ease of reading and for continuity when comparing against the removed sentences. In other words, it makes it easier to argue that this is an editorial change.

Copy link
Contributor

@cconcolato cconcolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the last sentence of section 10 which seems obvious to me and not necessarily, I'm fine with this PR.

Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a small but I think worthwhile editorial change.

spec/ttml2.xml Outdated
@@ -7759,6 +7769,9 @@ unless explicitly permitted by an element type definition, an attribute in the <
should not be specified on an element unless it either applies to that element or denotes an inheritable style property.
If it does not apply to that element and does not denote an inheritable style property, then it must be ignored for the purpose
of non-validation processing. In the case of validation processing, such usage should be reported as a warning.</p>
<p>For the purpose of determining the applicability of a style property, if the style property is defined so as to apply to a
<loc href="#content-vocabulary-span"><el>span</el></loc> element, then it also applies to
<loc href="#terms-anonymous-span">anonymous span</loc> elements.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a helpful line to add to the spec, but I would prefer to explicitly state that character children of p elements are considered to be enclosed in those anonymous spans. Perhaps reword to:

For the purpose of determining the applicability of a style property, if the style property is defined 
so as to apply to a <loc href="#content-vocabulary-span"><el>span</el></loc> element, then it also 
applies to the <loc href="#terms-anonymous-span">anonymous span</loc> elements that enclose 
any character content children of <loc href="#content-vocabulary-"><el>p</el></loc> elements.

In a way this could be seen as duplication of the definition of anonymous span, but I think it would be helpful for ease of reading and for continuity when comparing against the removed sentences. In other words, it makes it easier to argue that this is an editorial change.

@skynavga
Copy link
Collaborator Author

@nigelmegitt the language you suggest would be redundant or possibly read as contradicting the statement found in 8.1.5:

If a sequence of children of a p element consists solely of character information items, then that sequence must be considered to be an anonymous span for the purpose of applying style properties that apply to span elements.

@css-meeting-bot
Copy link
Member

The Working Group just discussed Collapse language for style application to paragraph text nodes; add … ttml2#803, and agreed to the following:

  • SUMMARY: Duplicate anonymous span text from p element into span element (for @skynavga) and reference the [create anonymous span] procedure from both.
The full IRC log of that discussion <nigel> Topic: Collapse language for style application to paragraph text nodes; add … ttml2#803
<nigel> github: https://github.com//pull/803
<nigel> Glenn: I added a comment to this.
<nigel> Cyril: Can we add a link from the sentence in 8.1.5 to the process for creating anonymous spans?
<nigel> Glenn: Yes, and come to think of it we should add the same text to the span element to
<nigel> .. make it complete. Right now it is incomplete.
<nigel> Cyril: I don't want it to look like there's a separate procedure.
<nigel> Glenn: That gives me a tbd on this before you sign off on it Nigel
<nigel> Nigel: OK
<nigel> .. Should we add a note pointing the reader to anonymous spans beneath the new text?
<nigel> Glenn: I don't want another place where we paraphrase what the construct anonymous span
<nigel> .. procedure does.
<nigel> Nigel: I was thinking of a note with a reference, but I take your point.
<nigel> Glenn: The terms anonymous span and span already take you to the right definitions.
<nigel> Nigel: Yes, if you add that anonymous span text from p to span then yes, I'm okay with that.
<nigel> SUMMARY: Duplicate anonymous span text from p element into span element (for @skynavga) and reference the [create anonymous span] procedure from both.

@skynavga
Copy link
Collaborator Author

@nigelmegitt addressed actions from SUMMARY above; should be good to go

@skynavga skynavga merged commit 2370552 into master Jun 1, 2018
@skynavga skynavga removed their assignment Jun 1, 2018
@skynavga skynavga deleted the issue-0533-anonymous-spans branch June 28, 2018 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants