Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove around and between in rubyReserve (#811). #812

Merged
merged 9 commits into from
Jun 7, 2018

Conversation

cconcolato
Copy link
Contributor

@cconcolato cconcolato commented Jun 1, 2018

Closes #811

@cconcolato cconcolato requested a review from skynavga June 1, 2018 19:40
@skynavga skynavga changed the title remove around and between in rubyReserve (#811) Remove around and between in rubyReserve (#811). Jun 1, 2018
@cconcolato cconcolato requested a review from palemieux June 1, 2018 22:00
@skynavga skynavga self-assigned this Jun 1, 2018
@skynavga skynavga added this to the CR2 milestone Jun 1, 2018
Copy link
Contributor

@palemieux palemieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cconcolato @skynavga What is the use case for "auto"? In particular, how is the author expected to use it in conjunction with values of itts:rubyPosition? Note that the example below does not show any difference between "auto" and "outside".

The four images images/rubyReserve_7A_around.png and images/rubyReserve_8A_between.png need to be removed, right?

@skynavga
Copy link
Collaborator

skynavga commented Jun 4, 2018

@palemieux addressed #812 (review) in 6ef7ada; I had also been pondering the removal of auto, which did have a subtle difference with outside since it was originally defined in terms of around in the case of more than one line, and around applied before to all but the last line while outside applies after to all but the first line; my conclusion is that we should remove auto since it will be confusing to have both auto and outside due to this subtle difference, and I'm doubtful there is a strong use case for the former around semantics anyway; note that this change upgrades this PR to substantive

@palemieux
Copy link
Contributor

@skynavga skynavga merged commit f3f3eef into master Jun 7, 2018
@skynavga skynavga removed their assignment Jun 7, 2018
@skynavga
Copy link
Collaborator

skynavga commented Jun 7, 2018

Merged early per WG resolution.

@skynavga skynavga deleted the issue-0811-rubyReserve-cleaning branch June 28, 2018 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants