Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve constraints on 'tts:rubyPosition' usage (#832). #833

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Improve constraints on 'tts:rubyPosition' usage (#832). #833

merged 1 commit into from
Jun 14, 2018

Conversation

skynavga
Copy link
Collaborator

Closes #832.

@skynavga skynavga added this to the CR2 milestone Jun 14, 2018
@skynavga skynavga self-assigned this Jun 14, 2018
@skynavga skynavga requested a review from palemieux June 14, 2018 09:54
@skynavga skynavga mentioned this pull request Jun 14, 2018
Closed
nigelmegitt
nigelmegitt reviewed Jun 14, 2018
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it addresses the issue to me, but I'd like @palemieux 's view too, since he raised the issue.

@skynavga skynavga merged commit f1899e3 into master Jun 14, 2018
@skynavga skynavga removed their assignment Jun 14, 2018
@skynavga
Copy link
Collaborator Author

Merged early per WG resolution.

@skynavga skynavga deleted the issue-0832-ruby-position branch June 28, 2018 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nigelmegitt nigelmegitt nigelmegitt left review comments

@cconcolato cconcolato cconcolato approved these changes

@palemieux palemieux palemieux approved these changes

Assignees
No one assigned
Labels
pr merged early substantive
Projects
None yet
Milestone
1ED-CR2
Development

Successfully merging this pull request may close these issues.
4 participants
@skynavga @cconcolato @palemieux @nigelmegitt