-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature extensions to standard profiles; minor fixes to #bidi*, #… #842
Conversation
…displayAlign*, #opacity* (#379).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be one typo, otherwise looks good to me.
spec/profiles/ttml2-full.xml
Outdated
<feature value="required">#unicodeBidi</feature> | ||
<feature value="required">#unicodeBidi-isolate</feature> | ||
<feature value="required">#unicodeBidi-version-2</feature> | ||
<feature value="required" extends="#unicode">#unicodeBidi-version-2</feature> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/extends="#unicode"
/extends="#unicodeBidi"
spec/profiles/ttml2-presentation.xml
Outdated
<feature value="optional">#unicodeBidi</feature> | ||
<feature value="optional">#unicodeBidi-isolate</feature> | ||
<feature value="optional">#unicodeBidi-version-2</feature> | ||
<feature value="optional" extends="#unicode">#unicodeBidi-version-2</feature> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/extends="#unicode"
/extends="#unicodeBidi"
@@ -242,7 +242,7 @@ | |||
<feature value="optional">#timeContainer</feature> | |||
<feature value="optional">#unicodeBidi</feature> | |||
<feature value="optional">#unicodeBidi-isolate</feature> | |||
<feature value="optional">#unicodeBidi-version-2</feature> | |||
<feature value="optional" extends="#unicode">#unicodeBidi-version-2</feature> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/extends="#unicode"
/extends="#unicodeBidi"
@nigelmegitt fixed |
…displayAlign*, #opacity* (#379).
Closes #379.