Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo (#857). #866

Merged
merged 3 commits into from Jul 11, 2018
Merged

Fix typo (#857). #866

merged 3 commits into from Jul 11, 2018

Conversation

skynavga
Copy link
Collaborator

Closes #857.

@skynavga skynavga added this to the PR milestone Jun 28, 2018
@skynavga skynavga self-assigned this Jun 28, 2018
@nigelmegitt
Copy link
Contributor

This looks fine to me, but since @TairT opened the issue I'd like to give him a little while longer to review.

@skynavga
Copy link
Collaborator Author

skynavga commented Jul 3, 2018

@TairT ping

@css-meeting-bot
Copy link
Member

The Working Group just discussed Fix typo (#857). ttml2#866.

The full IRC log of that discussion <nigel> Topic: Fix typo (#857). ttml2#866
<nigel> github: https://github.com//pull/866
<nigel> Glenn: This doesn't need Andreas's review in my opinion, it is just a typo fix to change
<nigel> .. "extended area" to "extended rectangle" which is the term used in XSL-FO and was
<nigel> .. intended.
<nigel> Nigel: I'd still like to give Andreas a week to review it - if he hasn't managed to by
<nigel> .. then then I will go ahead and approve it.
<nigel> Glenn: Ok

andreastai
andreastai approved these changes Jul 11, 2018
View reviewed changes
Copy link

@andreastai andreastai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change and for waiting. The change looks good to me.

@skynavga skynavga merged commit 0e7714a into master Jul 11, 2018
@skynavga skynavga removed their assignment Jul 11, 2018
@skynavga skynavga modified the milestones: PR, CR3 Jul 19, 2018
@skynavga skynavga deleted the issue-0857-typo branch October 4, 2018 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreastai andreastai andreastai approved these changes

@nigelmegitt nigelmegitt Awaiting requested review from nigelmegitt

Assignees
No one assigned
Labels
editorial
Projects
None yet
Milestone
1ED-CR3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@skynavga @nigelmegitt @css-meeting-bot @andreastai