Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXAMPLE 1] Is Example 1 technically a Linked Data document or just a Simple Document? #14

Closed
mwherman2000 opened this issue Jan 5, 2019 · 7 comments
Labels
CR1 This item was processed during the first Candidate Recommendation phase. pr exists A pull request exists to address this issue.

Comments

@mwherman2000
Copy link

In https://w3c-dvcg.github.io/ld-signatures/#ex-1-a-simple-linked-data-document, it states...

EXAMPLE 1: A simple Linked Data document
{
"@context": "https://w3id.org/identity/v1",
"title": "Hello World!"
}

Is this technically a Linked Data compliant document? ...it's impossible to tell from the definition of the linked data document in the Terminology section (see Issue https://github.com/w3c-dvcg/ld-signatures/issues/23)

@mwherman2000 mwherman2000 changed the title [EXAMPLE 1] Is Example 1, technically a Linked Data document or is just a Simple Document? [EXAMPLE 1] Is Example 1 technically a Linked Data document or is just a Simple Document? Jan 5, 2019
@mwherman2000 mwherman2000 changed the title [EXAMPLE 1] Is Example 1 technically a Linked Data document or is just a Simple Document? [EXAMPLE 1] Is Example 1 technically a Linked Data document or just a Simple Document? Jan 5, 2019
@dmitrizagidulin dmitrizagidulin transferred this issue from w3c-ccg/ld-signatures Mar 3, 2020
@msporny
Copy link
Member

msporny commented Feb 11, 2023

Example 1 has been updated to remove @context... it now reads "A simple JSON data document":

https://w3c.github.io/vc-data-integrity/#example-a-simple-json-data-document

Closing.

@msporny msporny closed this as completed Feb 11, 2023
@mwherman2000
Copy link
Author

mwherman2000 commented Feb 11, 2023

@msporny Are Example 1 (and Example 2) considered to be credentials that are compliant with Verifiable Credential V2 specification?

Reference: https://w3c.github.io/vc-data-integrity/#example-a-simple-json-data-document

@msporny
Copy link
Member

msporny commented Feb 11, 2023

@msporny Are Example 1 (and Example 2) considered to be credentials that are compliant with Verifiable Credential V2 specification?

No, and they don't need to be to use the Data Integrity specification.

@mwherman2000
Copy link
Author

mwherman2000 commented Feb 11, 2023

No, and they don't need to be to use the Data Integrity specification.

Understoood. Just the same, a clarifying comment needs to be added. Especially given the title of your spec is:

Verifiable Credential Data Integrity 1.0
This specification describes mechanisms for ensuring the authenticity and integrity of Verifiable Credentials and similar types of constrained digital documents using cryptography, especially through the use of digital signatures and related mathematical proofs.

@msporny
Copy link
Member

msporny commented Feb 12, 2023

and similar types of constrained digital documents

The examples fall under this category ^^^

What sort of clarifying statement would you like to see in the document?

I'm re-opening this issue now, given that you have requested changes.

@msporny msporny reopened this Feb 12, 2023
@mwherman2000
Copy link
Author

mwherman2000 commented Feb 12, 2023

@msporny When I look at the surrounding text, I feel the explanation would be somewhat convoluted.
Also, Example 1 doesn't contribute very much to the data integrity discussion.

Recommendation: Remove Example 1 and related text ...or... change/fix the title (e.g. Credential Data Integrity spec) and then position Example 1 as a credential with no credential data integrity features/capabilities. "Level zero" support.

Which of the remaining examples are also not VC2 compliant?

@msporny
Copy link
Member

msporny commented Jul 2, 2023

PR #105 has been raised to address this issue. This issue will be closed once that PR has been merged.

@msporny msporny added pr exists A pull request exists to address this issue. CR1 This item was processed during the first Candidate Recommendation phase. labels Jul 2, 2023
@msporny msporny closed this as completed Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR1 This item was processed during the first Candidate Recommendation phase. pr exists A pull request exists to address this issue.
Projects
None yet
Development

No branches or pull requests

2 participants