Clarify language around ZKP data format #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
brentzundel
requested review from
msporny,
OR13,
selfissued,
decentralgabe and
awoie
as code owners
dlongley
approved these changes
Apr 22, 2023
msporny
approved these changes
Apr 22, 2023
|
Perhaps example 17 in section 5.4 could also be updated. Currently the example provides a |
Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
|
@stenreijers I've updated the PR to remove the confusing suffix |
decentralgabe
approved these changes
Apr 24, 2023
Sakurann
approved these changes
Apr 26, 2023
|
Editorial, multiple reviews, changes requested and made, no objections, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #949
This PR suggests some editorial changes to reduce confusion around some examples showing the use of
credentialSchemawith ZKPs.Preview | Diff