Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated entity to include abstract nouns #1269

Merged
merged 3 commits into from
Sep 26, 2023
Merged

updated entity to include abstract nouns #1269

merged 3 commits into from
Sep 26, 2023

Conversation

jandrieu
Copy link
Contributor

@jandrieu jandrieu commented Sep 6, 2023

Address issue #1235

terms.html Outdated Show resolved Hide resolved
terms.html Outdated Show resolved Hide resolved
terms.html Outdated Show resolved Hide resolved
Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small tweaks, above

Copy link
Member

@brentzundel brentzundel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with Ted's suggestions

Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming my suggestion will be applied.

terms.html Outdated Show resolved Hide resolved
Thanks, TallTEd

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
terms.html Outdated Show resolved Hide resolved
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@iherman
Copy link
Member

iherman commented Sep 15, 2023

The issue was discussed in a meeting on 2023-09-14

  • no resolutions were taken
View the transcript

1.3. updated entity to include abstract nouns (pr vc-data-model#1269)

See github pull request vc-data-model#1269.

Brent Zundel: Raised by JoeAndrieu, suggesting changes to terminology.
� Few approvals, one request for changes from TallTed.

Ted Thibodeau Jr.: If changes are done, I'm ok merging.

Brent Zundel: not merging yet, close to being merged. We'll move on.

Joe Andrieu: FYI edits for #1269 accepted. #1269.

@brentzundel
Copy link
Member

the vocabulary still uses the word entity to describe the subject. I think this should also be changed to thing, but I believe that is an action for @iherman independent of this PR.

A thing with distinct and independent existence, such as a person,
organization, or device that performs one or more roles in the ecosystem.
</dd>
Anything that can be referenced in statements as an abstract or concrete noun.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems more correct to me, but no objection if we move forward with "as":

Suggested change
Anything that can be referenced in statements as an abstract or concrete noun.
Anything that can be referenced in statements by an abstract or concrete noun.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think either can be used. Alternatively --

Suggested change
Anything that can be referenced in statements as an abstract or concrete noun.
Anything that an abstract or concrete noun in a statement can reference.

Copy link
Member

@msporny msporny Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to merge this given the time window for merge has long since passed with no objections. I'm going with the original as it feels more clear to me.

</dd>
Anything that can be referenced in statements as an abstract or concrete noun.
Entities include but are not limited to people, organizations, physical things, documents,
abstract concepts, numbers, and strings. Any entity may perform roles
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
abstract concepts, numbers, and strings. Any entity may perform roles
abstract concepts, numbers, and strings. Any entity might perform roles

Entities include but are not limited to people, organizations, physical things, documents,
abstract concepts, numbers, and strings. Any entity may perform roles
in the ecosystem, if it is capable of doing so. Note that some
entities fundamentally cannot take actions, e.g., the string "abc"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
entities fundamentally cannot take actions, e.g., the string "abc"
entities fundamentally cannot take actions; for example, the string "abc"

@msporny
Copy link
Member

msporny commented Sep 26, 2023

Editorial, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit 3bd766b into w3c:main Sep 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants