-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated entity to include abstract nouns #1269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small tweaks, above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with Ted's suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving assuming my suggestion will be applied.
Thanks, TallTEd Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
The issue was discussed in a meeting on 2023-09-14
View the transcript1.3. updated entity to include abstract nouns (pr vc-data-model#1269)See github pull request vc-data-model#1269. Brent Zundel: Raised by JoeAndrieu, suggesting changes to terminology. Ted Thibodeau Jr.: If changes are done, I'm ok merging. Brent Zundel: not merging yet, close to being merged. We'll move on. |
the vocabulary still uses the word |
A thing with distinct and independent existence, such as a person, | ||
organization, or device that performs one or more roles in the ecosystem. | ||
</dd> | ||
Anything that can be referenced in statements as an abstract or concrete noun. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems more correct to me, but no objection if we move forward with "as":
Anything that can be referenced in statements as an abstract or concrete noun. | |
Anything that can be referenced in statements by an abstract or concrete noun. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think either can be used. Alternatively --
Anything that can be referenced in statements as an abstract or concrete noun. | |
Anything that an abstract or concrete noun in a statement can reference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to merge this given the time window for merge has long since passed with no objections. I'm going with the original as it feels more clear to me.
</dd> | ||
Anything that can be referenced in statements as an abstract or concrete noun. | ||
Entities include but are not limited to people, organizations, physical things, documents, | ||
abstract concepts, numbers, and strings. Any entity may perform roles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
abstract concepts, numbers, and strings. Any entity may perform roles | |
abstract concepts, numbers, and strings. Any entity might perform roles |
Entities include but are not limited to people, organizations, physical things, documents, | ||
abstract concepts, numbers, and strings. Any entity may perform roles | ||
in the ecosystem, if it is capable of doing so. Note that some | ||
entities fundamentally cannot take actions, e.g., the string "abc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
entities fundamentally cannot take actions, e.g., the string "abc" | |
entities fundamentally cannot take actions; for example, the string "abc" |
Editorial, multiple reviews, changes requested and made, no objections, merging. |
Address issue #1235