Removing sha3 reference from the vocabulary table. #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iherman
added
editorial
iherman
requested review from
msporny,
selfissued and
decentralgabe
as code owners
dlongley
approved these changes
Mar 14, 2024
decentralgabe
approved these changes
Mar 14, 2024
msporny
reviewed
Mar 23, 2024
msporny
reviewed
Mar 23, 2024
msporny
approved these changes
Mar 23, 2024
msporny
force-pushed
the
remove-sha3-1455
branch
from
cf1917f
to
137996d
Compare
|
Editorial, multiple reviews, changes requested and made, no objections, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the WG discussion on #1455 did not formally conclude (due to a lack of meeting time), I have the feeling that we were heading for a consensus to remove the sha3 hashes from the vocabulary table. This PR just does that.
Preview | Diff