Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test vectors to use did:key as the verification method. #72

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

Wind4Greg
Copy link
Collaborator

@Wind4Greg Wind4Greg commented Aug 22, 2024

This informative only PR updates all test vectors to use the did:key verification method. Previously only the ECDSA-SD test vectors used did:key. This PR ensures consistency and simplifies developer testing. Note only ReSpec included JSON files were changed. No changes were made to explanatory text.


Preview | Diff

Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- confirmed that the ecdsa-rdfc-2019 test vectors work with our implementation.

@msporny msporny added editorial The item is editorial in nature. CR1 labels Aug 28, 2024
@msporny
Copy link
Member

msporny commented Aug 28, 2024

Editorial, multiple reviews, no changes requested, no objections, test vectors confirmed via independent implementations, merging.

@msporny msporny merged commit 36e8159 into w3c:main Aug 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR1 editorial The item is editorial in nature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants