Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verification algorithms #261

Merged
merged 16 commits into from
Apr 3, 2024
Merged

verification algorithms #261

merged 16 commits into from
Apr 3, 2024

Conversation

brentzundel
Copy link
Member

@brentzundel brentzundel commented Mar 28, 2024

The PR adds verification algorithms for each of the securing mechanisms defined in the spec according to the guidance in the VC Data Model


Preview | Diff

Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
Copy link
Collaborator

@decentralgabe decentralgabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better!

index.html Outdated Show resolved Hide resolved
Copy link
Collaborator

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Verification Algorithms" section now contains the subsection

Algorithm for verifying a credential or presentation secured with SD-JWT

But I would have expected it to also contain the corresponding subsections

Algorithm for verifying a credential or presentation secured with JOSE
Algorithm for verifying a credential or presentation secured with COSE

I would suggest placing them in the order JOSE, SD-JWT, and COSE, as is done in https://w3c.github.io/vc-jose-cose/#securing-the-vc-data-model .

Co-authored-by: Michael B. Jones <michael_b_jones@hotmail.com>
Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small tweaks

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
brentzundel and others added 8 commits March 29, 2024 10:32
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
…he respective JSOE and COSE sections

Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
index.html Outdated Show resolved Hide resolved
@brentzundel brentzundel marked this pull request as ready for review March 29, 2024 16:42
index.html Outdated Show resolved Hide resolved
index.html Outdated
Comment on lines 2563 to 2564
Convert the SD-JWT payload back into the JSON claim set by reversing the process
described in [[[SD-JWT]]] [[SD-JWT]]. Set <code>document</code> to the JSON claim set.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot figure out what section of [[SD-JWT]] describes the process that is supposed to be reversed. I think this reference should converted be a section-specific data-cite.

Copy link
Member

@TallTed TallTed Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Moved to a top-level comment on the PR)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The process for moving from a JSON claim set to an SD-JWT payload is a description spread across a large swath of the SD-JWT document, rather than nicely contained in a single section. I have added a link to the appendix of examples in 3ff1693, which I hope is sufficient.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated
this media type. The unsecured [=verifiable credential=] is the input JSON
claim set. The Issuer then converts the input JSON claim set (i.e., the
unsecured [=verifiable credential=]) into an SD-JWT payload according to
[[[SD-JWT]]] [[SD-JWT]].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 424 should probably be changed from [[[SD-JWT]]] to a data-cite targeting the specific section.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjusted in 8c3772b

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
brentzundel and others added 4 commits March 29, 2024 13:19
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Michael B. Jones <michael_b_jones@hotmail.com>
Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
@TallTed
Copy link
Member

TallTed commented Mar 29, 2024

Answering a question which has now been deleted, because others may share it.

Triple brackets show the full title of the referenced document, and link directly there; e.g., ReSpec turns
[[[SD-JWT]]]
into
[Selective Disclosure for JWTs (SD-JWT)](https://datatracker.ietf.org/doc/html/draft-ietf-oauth-selective-disclosure-jwt)
, which renders as
Selective Disclosure for JWTs (SD-JWT).

Double brackets put a simple [cite] in the document body, which links to its citation in the references appendix, e.g., ReSpec turns
[[SD-JWT]]
in the PR-Preview of this PR turns into
[[SD-JWT](https://pr-preview.s3.amazonaws.com/brentzundel/vc-jose-cose/pull/261.html#bib-sd-jwt)]
, which renders as
[SD-JWT].

When put together,
[[[SD-JWT]]] [[SD-JWT]]
, renders as
Selective Disclosure for JWTs (SD-JWT) [SD-JWT].

Generally speaking, in [[cite]] reads very badly in the body text, and just links to the appendix, while in [[[cite]]] [[cite]] produces a far better result in the text.

(There are many other instances of title [[cite]] in the existing document which I think would be better changed to [[[cite]]] [[cite]].)

@selfissued selfissued merged commit 8673f36 into w3c:main Apr 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants