-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
verification algorithms #261
Conversation
Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much better!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Verification Algorithms" section now contains the subsection
Algorithm for verifying a credential or presentation secured with SD-JWT
But I would have expected it to also contain the corresponding subsections
Algorithm for verifying a credential or presentation secured with JOSE
Algorithm for verifying a credential or presentation secured with COSE
I would suggest placing them in the order JOSE, SD-JWT, and COSE, as is done in https://w3c.github.io/vc-jose-cose/#securing-the-vc-data-model .
Co-authored-by: Michael B. Jones <michael_b_jones@hotmail.com>
Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small tweaks
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
…he respective JSOE and COSE sections Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
index.html
Outdated
Convert the SD-JWT payload back into the JSON claim set by reversing the process | ||
described in [[[SD-JWT]]] [[SD-JWT]]. Set <code>document</code> to the JSON claim set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot figure out what section of [[SD-JWT]] describes the process that is supposed to be reversed. I think this reference should converted be a section-specific data-cite
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Moved to a top-level comment on the PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The process for moving from a JSON claim set to an SD-JWT payload is a description spread across a large swath of the SD-JWT document, rather than nicely contained in a single section. I have added a link to the appendix of examples in 3ff1693, which I hope is sufficient.
index.html
Outdated
this media type. The unsecured [=verifiable credential=] is the input JSON | ||
claim set. The Issuer then converts the input JSON claim set (i.e., the | ||
unsecured [=verifiable credential=]) into an SD-JWT payload according to | ||
[[[SD-JWT]]] [[SD-JWT]]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 424 should probably be changed from [[[SD-JWT]]]
to a data-cite
targeting the specific section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adjusted in 8c3772b
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com> Co-authored-by: Michael B. Jones <michael_b_jones@hotmail.com>
Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
Answering a question which has now been deleted, because others may share it. Triple brackets show the full title of the referenced document, and link directly there; e.g., ReSpec turns Double brackets put a simple [cite] in the document body, which links to its citation in the references appendix, e.g., ReSpec turns When put together, Generally speaking, (There are many other instances of |
The PR adds verification algorithms for each of the securing mechanisms defined in the spec according to the guidance in the VC Data Model
Preview | Diff