Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address part of 210 #212

Merged
merged 5 commits into from
Sep 12, 2023
Merged

Address part of 210 #212

merged 5 commits into from
Sep 12, 2023

Conversation

decentralgabe
Copy link
Collaborator

@decentralgabe decentralgabe commented Sep 5, 2023 •
edited by pr-preview bot
Loading

Address normative reference feedback from #210.

  • Remove unused refs in common.js
  • Rely on refs from existing specs instead of new refs

Preview | Diff

@decentralgabe decentralgabe mentioned this pull request Sep 5, 2023
Closed
@decentralgabe decentralgabe linked an issue Sep 6, 2023 that may be closed by this pull request
Pre-CR normative dependencies will trigger a 2nd CR #210
Closed
TallTed
TallTed requested changes Sep 7, 2023
View reviewed changes
Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small language tweaks

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@decentralgabe @TallTed
Apply suggestions from code review
0eb6dc0 
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@decentralgabe decentralgabe merged commit 6806113 into main Sep 12, 2023
1 check passed
@decentralgabe decentralgabe deleted the address-210 branch September 12, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallTed TallTed TallTed requested changes

@OR13 OR13 OR13 approved these changes

@andresuribe87 andresuribe87 Awaiting requested review from andresuribe87 andresuribe87 is a code owner

@msporny msporny Awaiting requested review from msporny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pre-CR normative dependencies will trigger a 2nd CR
3 participants
@decentralgabe @TallTed @OR13