Renamed name to title and added lang & dir.
#225
Conversation
|
"locale" is probably not the right name for this field, as it implies something about the processing environment or maybe the configuration of the host serving the credentials. A better model would probably be to follow some other specs and use Providing for multilingual |
andresuribe87
changed the title
name to title and added locale.name to title and added lang & dir.
|
Thanks @aphillips , I made the changes so we use |
| <a data-cite="ltli/#dfn-language-tag">language tag</a> for the values of the [=title=] and | ||
| [=description=] properties defined in the JSON Schema. The value of this field MUST be a | ||
| <a data-cite="ltli/#dfn-canonical-unicode-locale-identifier">canonical unicode locale identifier</a>. | ||
| When absent, implementers MUST assume that the value of this property is `en-US`. |
There was a problem hiding this comment.
I don't agree with this in app-manifest (I think we have an issue open against it?). The value when the language is not present should be und ("Undetermined", also known as the "root" locale)
There was a problem hiding this comment.
I'm not sure what issue/repo you may be referring to. Mind clarifying?
Curious, is that und guidance part of the LTLI spec?
I've updated this PR.
There was a problem hiding this comment.
Curious, is that und guidance part of the LTLI spec?
Actually, no, it's in String-Meta and the I18N Best Practices for Specs document. I've created an issue to add it to LTLI.
There was a problem hiding this comment.
approving pending @aphillips 's recommended changes. thanks for getting this up!
Fixes #224 by adding a
localefield.Additionally, this PR also renames
namein favor oftitle, because the latter is part of the json schema spec.Preview | Diff