-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated verify claim and added validate claim. images updated #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disambiguation for an international audience.
Please internationalize the term 'DMV'. This, I assume, is the US agency responsible for drivers licenses. In the UK we'd talk about the DVLA or just 'Swansea' for short (DVLA is based in the Welsh town of Swansea). Please re-phrase to say something like "the relevant government authority" or some such. This is a nit pick though. I find the text a very useful guide to distinguish between verify and validate. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've put a bunch of <br><br>
within <dd>
elements. It would probably be better to use <p>
, which often puts a half-line between paragraphs, rather than the full-line of <br><br>
.
The issue was discussed in a meeting on 2023-09-14
View the transcript2.6. Revisit validation vs verification (issue vc-data-model#1232)See github issue vc-data-model#1232. Brent Zundel: Raised by Orie on behalf of Joe... what do you need to write a PR here? Joe Andrieu: We have text in use cases document now, if people can look at the use case document, that would be helpful. See github pull request vc-use-cases#149.
Brent Zundel: To summarize -- verification checks syntax and cryptography checks out, validation has to do with business logic, and that's how verification and validation are different from one another. Manu Sporny: The only thing that jumps out is the use of normative language in the use cases document.
Manu Sporny: The core seems correct and is a clarification the VCDM would benefit from. Brent Zundel: any other comments from folks?
Brent Zundel: I hear concern about normative language, much broader concern about use cases document -- issue on use cases document would be a good way to track that. Manu Sporny: I'd be fine w/ an issue to track that ^. Brent Zundel: the normative language is bigger than just this PR. so a separate issue on the use cases document is probably the right place to go. Joe Andrieu: Yes, seniment feels like this is the right direction. Would like to hear from others on the queue. Challenge with normative language is that this is requirements for the spec, that's why we use normative language. Ted Thibodeau Jr.: We might want to use requirements language instead of normative statements. Brent Zundel: PR within the next week?
|
Accepting nearly all of @TallTed's recommendations. Just a few open threads remain. Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com> Co-authored-by: Gabe <7622243+decentralgabe@users.noreply.github.com> Co-authored-by: Sebastian Crane <seabass-labrax@gmx.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments added
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Just need to get that image in place, and we can merge. |
Images updated. Should be ready to merge. Please take a look, @KDean-GS1 |
Almost there. The Mermaid diagram could use some formatting help. I'll try to fix that. |
Preview | Diff