Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for Explicit Interop Test Suites from Mozilla #111

Merged
merged 6 commits into from
Jun 7, 2022

Conversation

mprorock
Copy link
Contributor

@mprorock mprorock commented Jun 4, 2022

per email on the AC list


Preview | Diff

@iherman
Copy link
Member

iherman commented Jun 4, 2022

cc @tantek

@clehner
Copy link
Member

clehner commented Jun 4, 2022

Copy link
Member

@brentzundel brentzundel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some suggested changes for better clarity.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
@brentzundel brentzundel changed the title Request for Explicit Interop Test Suites from Tantek Request for Explicit Interop Test Suites from Mozilla Jun 4, 2022
@brentzundel
Copy link
Member

@mprorock if you accept my suggestions I will approve this PR, thank you for raising it.

mprorock and others added 4 commits June 4, 2022 16:37
Co-authored-by: Brent Zundel <brent.zundel@gmail.com>
Co-authored-by: Brent Zundel <brent.zundel@gmail.com>
Co-authored-by: Brent Zundel <brent.zundel@gmail.com>
Co-authored-by: Brent Zundel <brent.zundel@gmail.com>
@mprorock
Copy link
Contributor Author

mprorock commented Jun 4, 2022

@mprorock if you accept my suggestions I will approve this PR, thank you for raising it.

Accepted - thanks for the extra eyes!

index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@Sakurann Sakurann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the typo in implementations before merging. Thank you for the PR

@iherman iherman self-requested a review June 5, 2022 04:25
@brentzundel
Copy link
Member

@msporny as you probably have the most direct experience with the current VC test suite, I am very interested in your opinion of these proposed changes.

index.html Outdated Show resolved Hide resolved
@mprorock
Copy link
Contributor Author

mprorock commented Jun 5, 2022

please fix the typo in implementations before merging. Thank you for the PR

corrected

Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and this would resolve the specific issue that Mozilla's Formal Objection was based on. Thanks for putting in this work!

@msporny
Copy link
Member

msporny commented Jun 7, 2022

@msporny as you probably have the most direct experience with the current VC test suite, I am very interested in your opinion of these proposed changes.

The more modern test suites that we're planning on using for the VC 2.0 work will be able to test interoperability in the way this PR is suggesting.

The only question I have is whether or not the test suites can utilize protocols to demonstrate interoperability? Given that test suites are non-normative, I suggest the answer to this question is "Yes, the test suite can utilize VC protocols to demonstrate interoperability." For example, the credential refresh and credential status require protocols to be used. I believe this would address Google and Mozilla's concerns, while not crossing the hard line that Microsoft has about the WG not working on protocols.

IOW, one way through this is to say the WG will not normatively define protocols, but can utilize protocols to demonstrate interoperability on VC 2.0 data model features. This all keeps going back to whether or not the VC2WG is generating data model specifications or data model + protocol specifications. I believe we have consensus to work on data models normatively and protocols non-normatively... and we can prove interoperability by using a combination of normative specification text and non-normative test suites (that utilize particular protocols).

@brentzundel brentzundel merged commit 0446a95 into w3c:main Jun 7, 2022
@iherman
Copy link
Member

iherman commented Jun 7, 2022

@msporny I do not think there is a problem. The text in the charter does not say how the interchange happens, that can be done via protocol agreed upon by parties, emails, or by snail mail...

@iherman
Copy link
Member

iherman commented Jun 7, 2022

I will start the formal process by W3M for the approval of the charter.

@iherman
Copy link
Member

iherman commented Jun 7, 2022

LGTM and this would resolve the specific issue that Mozilla's Formal Objection was based on. Thanks for putting in this work!

Thanks Tantek.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants