-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify VCDI deliverable #76
Conversation
… documents Signed-off-by: Brent Zundel <brent.zundel@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit concerned that once we get into the WG, certain individuals might try to remove half of the cryptosuites in the list. I'm also concerned that we don't specifically call out that BBS+ and JWP can't be standardized w/o the proper IETF work needing to be performed at IETF. That said, I'm fine w/ this if we can get the rest of the WG to consensus on these items.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @msporny concerns here that this change could be weaponized later, but I don't see any specific reasons that this change couldn't occur.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only reservation is with the VC-JWT reference, because that is, in fact, part of the existing standard and, therefore, may be considered as part of the other deliverable. It is not an Input Document.
I am not sure how to formalize this in the charter, but we may want to say that this deliverable may also include part of the current Data Model spec being moved to this deliverable (and remove the reference from the list of input documents), with a possible reference to the JWT section.
I am not an expert, but any reason why this is? |
Both BBS+ and JWP require that cryptographic primitive work is performed at IETF and standardized before we can package up the primitives into a W3C cryptosuite. Without that work being completed, we are not going to be able to normatively reference the appropriate cryptographic primitives in IETF RFCs. The previous text in the charter mentioned this concern, the current text in this PR doesn't. It is understood by all, I hope, that if we don't have the IETF RFCs to base the BBS+ and JWP work off of, that we won't be able to publish anything at W3C that normatively standardizes BBS+ and JWP usage. |
I think the goal here is to extract the VC-JWT section out of the VCDM spec and make it a standalone REC-track spec (just another cryptosuite-like spec) in order to make the VCDM spec cleaner. |
I understand that. But, to avoid any issues during review, we may want to make that clear because, again, that is not really an 'input document', like the others are. |
This PR addresses the concern I raised here: #54 |
|
||
<p class="draft-status"><b>Draft state:</b> | ||
<p class="input-documents"><b>Input documents:</b></p> | ||
<p>(the following are a non-exhaustive selection of expected input documents)</p> | ||
<a href="https://w3c-ccg.github.io/data-integrity-spec/">Data Integrity</a>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nit to be cleaned up later, but I think ul / li would be more readable than a comma separated list.
Yes, agreed. Although, I'm struggling to think of language that would clarify. My expectation is that no one will really catch on to this nuance (and if they do, it's easily explainable and shouldn't result in a Formal Objection). To put it another way, this PR removes the nuances that we had in the previous text... and that's probably a good thing. We don't want people quibbling over nuances because, ultimately, nuances are up to the WG to evaluate... not the Advisory Council. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that removing the references to some of the potential input documents, such as JWP, moves us in the wrong direction. Please update this PR to restore them. Thanks.
|
||
<p class="draft-status"><b>Draft state:</b> | ||
<p class="input-documents"><b>Input documents:</b></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a little concerned that there are multiple layers being mentioned without clarification of how they relate to expressing "proofs of integrity" - containers (JWTs, JWPs, etc), algorithms (BBS+, etc.), and concrete curves (secp256k1, ED25519, etc.)...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, agree with @Sakurann ... we might want to be specific about the layers:
- Container Formats
- Data Integrity
- VC-JWT
- VC-JWP
- Cryptosuites (a fair number of these can be mapped to an input document)
- JWS
- EdDSA
- NIST ECDSA
- Koblitz ECDSA
- NIST RSA
- BBS+
- PGP
- GOST DSA
- SM9 IBSA
Cryptographic algorithms and primitives are only to be taken from IETF and other standards organizations (e.g., SECG, X9, etc.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the word "Cryptosuites " is somewhat misleading...
"JWS" supports "EdDSA + NIST + Koblitz" ...
"PGP" supports "EdDSA + NIST + Koblitz" ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JWS is a "kitchen sink" cryptosuite -- it includes everything (except, of course, for the things it doesn't... like GOST, SM9, BLS, and secp256k1 for over a decade). :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to call out that if we believe key formats should be tied to container formats and cryptosuites than I think we'll need to add those to the list. Although I'm personally in favor of not defining them here and relying on key conversion techniques so that an X.509 cert or a JWK set published as a resource on the web, or a DID Document with verification methods could all be used with the same cryptosuites or container formats and key formats remain an implementation considerations.
</p> | ||
<p class="draft-status"><b>Draft state:</b> No Draft </p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrm, I missed this during the first go-around. We do have an input document here for the "Verifiable Credential Data Integrity 1.0" document... and that is the "Data Integrity" specification. We don't want to re-litigate that (as it took many months to do it last time). We may want to go with @Sakurann's suggestion below... which is to clearly articulate the draft documents at each layer. More below...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to ensure that we retain direct links to exactly what we are talking about - ok with categorization as suggested by @msporny
I'd be ok loosing the links and then adding them back... I would object to the charter in its current form or after this PR... it still needs a lot of work... I think we should try to merge things a bit faster and this section will probably needs good amount of cleanup before it becomes acceptable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per discussion on the 16-Feb-22 working group call, please do not merge this until the references that it currently deletes, such as JWP, have been restored. Thank you.
The issue was discussed in a meeting on 2022-02-16
View the transcript4.3. Simplify VCDI deliverable (pr vc-wg-charter#76)See github pull request vc-wg-charter#76. Brent Zundel: this PR attempts to clear up draft status. apologies to recent comments.. Manu Sporny: Christina raised a comment that is good to focus on.
Manu Sporny: we're not talking about a mishmash of documents that will be squished in to one document.. Michael Jones: added an issue comment that this pull removes references to work items..
Michael Jones: if we're going to consider this pull we should undo removing references.
Kyle Den Hartog: Manu's categories. key formats. will define whether we want these cryptosuites to fit the keys in. are we choosing key formats?.
Manu Sporny: +1 to Mike Jones. important things have been removed. this is a restructuring and we'll add the references back in later..
Brent Zundel: state specific feedback. keep engaging. consensus seems net-more.. |
The issue was discussed in a meeting on 2022-02-23
View the transcript4.5. Simplify VCDI deliverable (pr vc-wg-charter#76)See github pull request vc-wg-charter#76. Brent Zundel: the VCDI deliverable description was becoming messy... this PR simplifies the text... its a step towards the refactoring Manu does in his PR. Manu Sporny: +1 to that approach, I like the simplification, and the list approach.. Michael Jones: I commented on 76 some weeks ago asking for the deleted spec references to be restored.
Brent Zundel: its not intentional deletion, I was not sure how to include JWP, PR 77 adds it back in the correct place. Michael Jones: I would prefer that each PR does no damage. Brent Zundel: simplest route forward would be for you to suggest were JWP should go.. Michael Jones: it should be listed in non normative deliverables. Manu Sporny: can you make that change?. Michael Jones: i don't know how to edit other peoples PRs. Brent Zundel: PR 76, we want to make sure JWP is listed in this PR under.... non normative deliverables?. Manu Sporny: JWP should be listed under deliverables assuming IETF progress. Brent Zundel: lets look at 77. Manu Sporny: we responded to you in PR 77. Kristina Yasuda: can i talk about 77?. Michael Jones: as I just said, can we please fix the problems in 76, and then consider that independent of other PRs. Manu Sporny: the reason is that brent's simplification takes it out. Michael Jones: why not put it back in the PR?. Manu Sporny: because brent's PR deletes that section. Orie Steele: I believe we are all in agreement about the changes that we want to see. We want to see 76 merged, and we want to see 77 merged. We can't add VC-JWP back into 76 because of what Manu said. We need to clarify what we mean by conditional deliverables in PR 77.. Michael Jones: I understand what you are saying Manu, my intent is for you to put things back. Manu Sporny: I proposed adding it back to the end of the sentence. Michael Jones: there are other deletions.
Brent Zundel: those are still listed,.
Ted Thibodeau Jr.: are we ready to merge 76?. Brent Zundel: I believe we are. |
Simplify VCDI description, fix draft status, add description of input documents
Signed-off-by: Brent Zundel brent.zundel@gmail.com
Preview | Diff