Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best practices: recommend signing commits #66

Closed
wants to merge 1 commit into from
Closed

Conversation

tripu
Copy link
Member

@tripu tripu commented Dec 16, 2018

No description provided.

Copy link
Member

@vivienlacourba vivienlacourba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would vote -1 on that one for two reasons:

  • We should not add to our doc all the github recommendations (otherwise it will be quickly outdated) but only focus on the ones we think are the most important ones
  • It looks like not a lot of people in our community are signing their commits today and I have not heard that this is something that we should try to recommend as part of contributing to W3C Specifications (maybe that will change in the future)

@tripu
Copy link
Member Author

tripu commented Dec 20, 2018

OK, @vivienlacourba.
Let's recycle this PR if in the future this becomes more important and we start encouraging/enforcing it.

@tripu tripu closed this Dec 20, 2018
@tripu tripu deleted the tripu/sign-commits branch December 20, 2018 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants