Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Translations page #396

Merged
merged 5 commits into from
Apr 16, 2024
Merged

Update Translations page #396

merged 5 commits into from
Apr 16, 2024

Conversation

remibetin
Copy link
Member

@remibetin remibetin commented Feb 8, 2024

Direct link to French translations for example: https://deploy-preview-396--wai-website.netlify.app/translations/#fr

Goal here is to better align the presentation of this page with the new WCAG Translations page. Not a total redesign.

Key changes:

Resolves w3c/wai-translations#158

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for wai-website ready!

Name Link
🔨 Latest commit ff78862
🔍 Latest deploy log https://app.netlify.com/sites/wai-website/deploys/6615800227d9bd0008e6c331
😎 Deploy Preview https://deploy-preview-396--wai-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@remibetin
Copy link
Member Author

@shawna-slh What do you think of this presentation? Direct link to French translations for example: https://deploy-preview-396--wai-website.netlify.app/translations/#fr

Goal here is to better align the presentation of this page with the new WCAG Translations page. Not a total redesign.

Key changes:

@remibetin remibetin changed the title Try new Translations page New Translations page Feb 27, 2024
@remibetin remibetin changed the title New Translations page Update Translations page Feb 27, 2024
@remibetin remibetin marked this pull request as ready for review February 27, 2024 15:34
@shawna-slh
Copy link
Collaborator

@remibetin What about changing "Comment les personnes handicapées utilisent le web" and such to a heading instead of a nested DL?

@remibetin remibetin assigned remibetin and unassigned shawna-slh Feb 29, 2024
@remibetin remibetin assigned shawna-slh and unassigned remibetin Apr 9, 2024
@shawna-slh shawna-slh merged commit 9c4d001 into master Apr 16, 2024
5 checks passed
@shawna-slh shawna-slh deleted the new-translations-page branch April 16, 2024 16:21
@remibetin
Copy link
Member Author

QA done: ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants