-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI updates #57
Comments
WIP
Which icon needs to be there?
I did this, but dislike how it's turning out. Adding a long list at the top of the page pushes all the important content far down. I would prefer to either not have this ToC, or to have it collapsed by default. Don't quite know how to link to the expectations properly. There can be more than one, and the ID changes depending on if there is. Either "#expectation" or "#expectation-1".
I don't quite know what to do with this. |
I think this one: https://wai-website-theme.netlify.app/components/icons/#different-view (I'm confirming that works for Hidde w3c/wai-website#266 )
Thanks for giving it a try and bringing it back for additional consideration. When we did usability testing for the last redesign, a clear finding was that users wanted that Page Contents list at the top. We weren't even specifically looking for that in the UT and in some we had it on the right (e.g., https://www.w3.org/WAI/impl/software ) or not at all -- the overwhelming evidence was to add it. We did that throughout the WAI website redesign. It serves several purposes, including:
When EOWG was reviewing the ACT Rules recently, Carlos noted that a TOC would be useful. I am open to doing something different — not having it at all or having it collapsed by default — if the user experience warrants that. Given most ACT Rules users will be regular users and we are optimizing design for them (not the casual user that lands here accidentally or occasionally), I think we don't need it for #1 above. I don't know enough about how people will use these to say how useful #2 would be. My guess is pretty useful. I'm guessing #3 is somewhat useful. Maybe best to chat briefly to help me understand the expected user experience? Or, does above convince you? :-)
https://deploy-preview-51--wcag-act-rules.netlify.app/standards-guidelines/act/rules/html-page-non-empty-title-2779a5/ has a box under the h1. It is currently titled "Conformance Rule". Shadi and others thought a better title for that box would be "Rule Mapping". Does that make sense? (also, it needs to be left aligned) |
I think “Rule Mapping” is very jargony… across supporting documents, this box gives a quick summary of the document. In the case of a rule, the summary is information about how it maps, but I feel we could use a more generic phrase, something that is closer to the user's mental model. What about “About this Rule”? Fwiw I've also used “About this Technique” in Techniques. |
Note this is the WAI website footer, which always starts in the 4th column (the grid area called “content”). I feel we should leave it as is. |
I think it's all there. Work is spread over two PRs though: w3c/wai-website-theme#33 This updates the template with things we needed. Once that is merged we can create a new Netlify preview for this PR, which lets we'll need for a final review / CfC on this PR: #51 |
In my original designs we used the |
Thanks @WilcoFiers ! I have reviewed the PR. Thanks for fixing my comment so quickly, have approved and merged the changed in. |
After analysis of common use cases (I can't remember if that's documented somewhere other than e-mail -- if not,we should), Hidde and I decided best UI for the actual Rules would be H2s collapsed with Expand All - Collapse All button. There are some issues with JAWS bug that need to be worked out. OK to merge without for now. Please either leave this issue open, or create a new one for it. Thanks! |
Instead of Page Contents/TOC:
(If having an unknown number of Exceptions complicates things, it seems it would be fine for the user experience if there was
(@hidde plans to address the JAWS bug with site-wide update) |
Hey @WilcoFiers @nitedog @hidde @shawna-slh
If people think anything is missing feel free to edit this comment or add tasks in further comments. This way we all have a quick way to track these issues. |
@shawna-slh Changing the expectation heading structure is a significant departure from how ACT rules have been written in the past. The solution you suggested was discussed by ACT TF in the past and the current one was preferred. I would prefer to avoid re-opening old discussions. Can you live with the solution that we use currently? |
I am totally fine leaving the heading structure as is. Hopefully it is not too difficult to implement the collapsed headings so users get an overview of the page content, and can easily jump between the test cases and the expectations. (and all the other benefits described in previous issues. :-) |
Hey @shawna-slh @hidde @WilcoFiers I have tried excol component in
|
Hi @daniel-montalvo For sure we would need Expand All - Collapse All to be there. I'm not sure why Expand All - Collapse All is not showing up. (for trouble shooting: 1. I added it to another page -- and it's not showing up in that preview either. So I thought maybe it just doesn't show up in previews. 2. I did a preview of a page that already has it -- and it did show up.) I'll wait and see if @hidde has any insight before I spend more time on it. (I don't have enough perspective on how the specific test cases would be used to know it it is best to not have nested expand/collapses. I am fine going with what is easiest for now, and then asking users once they are out there.) |
@daniel-montalvo Just had a look at what might be going on. The 'expand/collapse all' component has two pieces that are needed for it to work: HTML and JS. The HTML part works: an empty div is outputted. The JS part does not, there is some code that executes based on the existence of that empty div, but that code fails. There is a log in the console about translations, I expect this stops further execution of that |
Hi @wilco I just notice one little thing in the footer -- the date format should be 00 Month 2021 in:
Reminder from e-mail:
|
@shawna-slh Where are you seeing this malformed date? |
Footer of all pages, e.g., https://wai-wcag-act-rules.netlify.app/standards-guidelines/act/rules/aria-attr-defined-5f99a7/ Unfortunately that is also not pulling the updated banner wording or asterisks icon removed. |
I think all of these issues have been addressed, or are no longer relevant. If not, please open new issue(s) for the specific open point. Thanks. |
Hi @WilcoFiers @kengdoj @daniel-montalvo . @hidde, @nitedog , and I had a chance to work on this together. Based on that, I propose the following edits.
On All Rules page:
For each individual Test Rule page:
a "Page Contents" list in box like throughout the WAI website (examples)collapsed
h2
s per comments belowThe text was updated successfully, but these errors were encountered: